fix(pipeline): assert result narrowed in invoke return path#243
Merged
miguelgfierro merged 1 commit intoMay 28, 2026
Merged
Conversation
After the try/finally introduced in #240, pyright could not narrow result: StatePipelineResult | None to StatePipelineResult at the return statement (a finally block can reassign, so the narrowing must be local). Add an explicit assert before return — same runtime guarantee, makes the non-None invariant visible to pyright.
ancongui
pushed a commit
that referenced
this pull request
May 31, 2026
…owing fix(pipeline): assert result narrowed in invoke return path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Type Check job failure on #232.
Pyright reported:
The single-return-path refactor in #240 declared
result: StatePipelineResult | None = Noneand assigned it inside thetryblock. Pyright cannot narrow it through atry/finallyboundary (afinallycan theoretically reassign), so at thereturn resultstatement it still seesNoneas a possibility.Add
assert result is not Nonebefore the return — same runtime guarantee (thetryblock always setsresulteither via abreakor via the post-loopif result is None:fallback), and pyright now sees the non-None invariant.Verification
pyright fireflyframework_agentic/pipeline/state_pipeline.py→ 0 errors.pytest tests/unit/pipeline/→ 142 passed.