fix(ci): satisfy stricter ruff rules on PR gate (#232)#254
Merged
Conversation
Three Ruff rules that the project ruff CI enforces but my local ruff missed (newer CI version): - SIM103 in engine.py:_is_send_payload — collapse the second if/return pair into a direct return. - F841 in test_pipeline_engine_pause_send.py — remove an unused 'planner' variable that was leftover from an earlier draft of test_single_send_is_treated_as_list_of_one. - N817 in same test file — rename 'Pause as P' / 'Send as S' to 'PausePkg'/'SendPkg' (single-letter CamelCase aliases trip the acronym rule). No behavior change. Tests still 7/7 in that file.
ancongui
pushed a commit
that referenced
this pull request
May 31, 2026
fix(ci): satisfy stricter ruff rules on PR gate (#232)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for the lint + pre-commit failures on #232.
Three rules that the CI ruff enforces but my local ruff didn't catch:
engine.py:_is_send_payload— secondif/returnpair collapsed into a directreturn.tests/unit/pipeline/test_pipeline_engine_pause_send.py— unusedplannervariable removed (leftover from an earlier draft oftest_single_send_is_treated_as_list_of_one).Pause as P/Send as Srenamed toPausePkg/SendPkg(single-letter CamelCase aliases trip the acronym rule).No behavior change. The 7 tests in that file still pass. Local
ruff check .is now clean.Targets
issue-147-pipeline-evolutionso #232 picks up the fix on the next CI run.