fix: harden security, complete plugin system, fix packages#8
Merged
fix: harden security, complete plugin system, fix packages#8
Conversation
…scan removal Part of the Firefly Framework hexagonal architecture remediation. - Remove @componentscan from ApplicationLayerAutoConfiguration - Add 8 explicit @bean @ConditionalOnMissingBean methods - Remove @Component/@service from 8 component classes - Use ObjectProvider for optional SessionManager dependency - Use interface-level @ConditionalOnMissingBean for Default* implementations
…ge structure - Implement real security authorization (roles/permissions enforcement) - SecurityAspect respects both global and annotation-level config source - Complete plugin system with JarPluginLoader and registry - Fix all package references from org.fireflyframework.application to org.fireflyframework.common.application - Add SecurityAutoConfiguration and ApplicationLayerProperties - Add JwtClaimsRoleExtractor for configurable JWT claim paths - Fix logback and application.yml logger names - Fix test constructor calls and assertion updates
casc84ab
approved these changes
Feb 13, 2026
Contributor
casc84ab
left a comment
casc84ab
left a comment
There was a problem hiding this comment.
LGTM - Real security authorization (roles/permissions), SecurityAspect now reads Spring MVC annotations for endpoint/method extraction. Plugin system with JarPluginLoader. Package references fixed. JwtClaimsRoleExtractor for configurable JWT paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan