Conversation
…figurations Add @AutoConfigureBefore and @ConditionalOnMissingBean guards to ObservabilityAutoConfiguration to prevent duplicate jobTracingService, jobMetricsService, and jobOrchestratorHealthIndicator beans when DataEnrichmentAutoConfiguration also defines them. Add @ConditionalOnMissingBean guard to StepEventPublisherBridge bean.
ancongui
approved these changes
Feb 13, 2026
Contributor
ancongui
left a comment
ancongui
left a comment
There was a problem hiding this comment.
LGTM. Two well-targeted fixes:
-
ObservabilityAutoConfiguration:@AutoConfigureBefore(DataEnrichmentAutoConfiguration.class)ensures correct ordering, and@ConditionalOnMissingBeanonjobTracingService,jobMetricsService, andjobOrchestratorHealthIndicatorprevents duplicates. Each conditional checks by type (class), which is the right approach. -
StepBridgeConfiguration: Same@ConditionalOnMissingBean(name = "stepEventPublisherBridge")guard as the paired domain PR #8.
Clean, minimal changes with clear intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@AutoConfigureBefore(DataEnrichmentAutoConfiguration.class)and@ConditionalOnMissingBeanguards toObservabilityAutoConfigurationforjobTracingService,jobMetricsService, andjobOrchestratorHealthIndicatorbeans@ConditionalOnMissingBean(name = "stepEventPublisherBridge")toStepBridgeConfigurationto prevent duplicate bean when both fireflyframework-domain and fireflyframework-data are on the classpathTest plan