refactor: hexagonal architecture remediation — IDP adapter selection#7
Merged
Merged
Conversation
Part of the Firefly Framework hexagonal architecture remediation. - Add firefly.idp.provider discriminator for runtime adapter selection - Rewrite auto-configuration with @ConditionalOnProperty + @ConditionalOnClass - Remove @componentscan in favor of explicit @bean methods - Remove @Service/@component from adapter implementation classes - Standardize property namespace under firefly.idp.* - Create/update .imports files for Spring Boot 3.x auto-configuration
…alerts Controller methods should be thin delegates — access logging belongs in a cross-cutting WebFilter or interceptor, not scattered across individual endpoints where user-supplied values risk log injection.
casc84ab
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IdpPropertieswithfirefly.idp.providerdiscriminator,IdpWebAutoConfigurationwith@ConditionalOnBean(IdpAdapter.class), and movedIdpControllerto coreKeycloakAutoConfigurationwith@ConditionalOnProperty(firefly.idp.provider=keycloak)+@ConditionalOnClass(Keycloak.class), removed stereotype annotations from 6 classes, foldedCorsConfigCognitoConfigurationas@AutoConfiguration, removed@ComponentScan, standardized prefix tofirefly.idp.cognito, created.importsfileInternalDbIdpConfigurationas@AutoConfiguration, removed@ComponentScan, standardized prefix tofirefly.idp.internal-db, created.importsfileapplication.yml— no POM changes needed to switch providersArchitecture Pattern
Each adapter follows the reference pattern:
Configuration
Test Plan