feat(core): SpEL-lite — @Value('#{...}') + @conditional_on_expression (v26.06.30)#55
Merged
Conversation
… + bump v26.06.30
Wave 4 — a SAFE subset of Spring SpEL for the #{...} form (ast-parsed, whitelisted node
types, never eval()): arithmetic, comparison, boolean, ternary, lists, literals,
${key:default} placeholder substitution (numeric values participate in arithmetic), env mapping.
- @value('#{...}') evaluates expressions (plain ${} + literals unchanged).
- @conditional_on_expression('#{...}') registers a bean when truthy (Spring
@ConditionalOnExpression), evaluated in the config pass.
- pyfly.core.expression.evaluate / ExpressionError / is_expression public.
Tests: tests/core/test_expression.py (7, incl. safety: rejects calls/attribute/unknown-name).
Gates: mypy --strict (613), ruff + format, full suite 3777 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 4 — a safe subset of Spring's SpEL for the
#{ ... }form.@Value("#{ ... }")evaluates arithmetic, comparison, boolean (and/or/not), ternary, lists/tuples, literals,${key:default}placeholder substitution (numeric values participate in arithmetic), and anenvmapping. Example:Value("#{${pyfly.workers} * 2}").@conditional_on_expression("#{ ... }")(pyfly.context) registers a bean when the expression is truthy — Spring's@ConditionalOnExpression, evaluated in the config pass.ast, evaluated against a whitelist of node types — no attribute access, no function/method calls, no imports;evalis never used.evaluate/ExpressionError/is_expressionare public inpyfly.core.expression.Plain
${key}placeholders and literal@Valuestrings are unchanged.Tests
tests/core/test_expression.py(7): arithmetic/boolean/ternary, placeholder substitution + numeric defaults,env, safety (rejects__import__, attribute access, unknown names),@ValueSpEL,@conditional_on_expressionviaConditionEvaluator.Gates
mypy --strict(613) ✓ ·ruff+ruff format✓ · full suite 3777 passed, 1 skipped.Bumps
v26.06.29 → v26.06.30. Wave 4 remaining: Testcontainers. Then Wave 5 (docs + skills/agents).