Skip to content

Fix: Remove duplicate HttpRequestLoggingWebFilter component annotation#10

Merged
ancongui merged 1 commit into
developfrom
fix/resolve-duplicate-bean-registrations
Feb 13, 2026
Merged

Fix: Remove duplicate HttpRequestLoggingWebFilter component annotation#10
ancongui merged 1 commit into
developfrom
fix/resolve-duplicate-bean-registrations

Conversation

@casc84ab
Copy link
Copy Markdown
Contributor

Summary

  • Remove @Component from HttpRequestLoggingWebFilter since it is already registered via auto-configuration, preventing duplicate bean registration at startup

Test plan

  • All 174 fireflyframework-web tests pass
  • All 36 microservice repos compile and pass tests
  • 29/36 microservices start cleanly with zero duplicate bean warnings

Remove @component from HttpRequestLoggingWebFilter since it is already
registered via auto-configuration, preventing duplicate bean registration.
@casc84ab casc84ab requested a review from ancongui February 13, 2026 16:00
Copy link
Copy Markdown
Contributor

@ancongui ancongui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean fix — removing the redundant @Component is the correct approach since the class is already registered via auto-configuration. The @EnableConfigurationProperties annotation stays, which is appropriate since it's needed for the properties binding.

Verified: CI passes, no concerns with this minimal 2-line deletion.

@ancongui ancongui merged commit 6f44887 into develop Feb 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants