Skip to content

added affiliate endpoints#111

Merged
NidaKarimAli merged 3 commits intomainfrom
nida/bfs-1464-add-affiliate-endpoints-to-pro-sdk
May 26, 2025
Merged

added affiliate endpoints#111
NidaKarimAli merged 3 commits intomainfrom
nida/bfs-1464-add-affiliate-endpoints-to-pro-sdk

Conversation

@NidaKarimAli
Copy link
Copy Markdown
Contributor

No description provided.

@NidaKarimAli NidaKarimAli requested a review from a team May 23, 2025 18:29
bearerFormat: JWT
schemas:
CampaignRewards:
Error:
Copy link
Copy Markdown
Contributor

@kevin-ip kevin-ip May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the ./common.yaml#/components/schemas/Error to promote code reuse. So that we won't run into this issue again.

Comment thread resources/rewards-data-api.yaml Outdated
Comment thread resources/rewards-data-api.yaml Outdated
Comment thread resources/rewards-data-api.yaml
@MemoAlfa
Copy link
Copy Markdown
Contributor

Great, that reminds me we need to bring back linters and codegen verifiers

@NidaKarimAli NidaKarimAli requested a review from kevin-ip May 26, 2025 04:05
Copy link
Copy Markdown
Contributor

@kevin-ip kevin-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly reminder to update the openapi.yaml in the reward service

@NidaKarimAli NidaKarimAli merged commit 76f440f into main May 26, 2025
@NidaKarimAli NidaKarimAli deleted the nida/bfs-1464-add-affiliate-endpoints-to-pro-sdk branch May 26, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants