add order type in trades response#115
Merged
burhanuddin03 merged 2 commits intomainfrom May 27, 2025
Merged
Conversation
Contributor
burhanuddin03
commented
May 27, 2025
burhanuddin03
commented
- add order type in trades response
alawrenc
approved these changes
May 27, 2025
nikita-seedlabs
approved these changes
May 27, 2025
kevin-ip
approved these changes
May 27, 2025
| type: string | ||
| description: Order hash. | ||
| orderType: | ||
| $ref: "#/components/schemas/OrderType" |
Contributor
There was a problem hiding this comment.
Have we updated ADS, EVS and WS?
Contributor
Author
There was a problem hiding this comment.
ADS is updated. Do we also need to update EVS and WS?
Contributor
Author
There was a problem hiding this comment.
I am gonna merge this as Onur is blocked. Will see what needs to be done in EVS and WS.
Contributor
There was a problem hiding this comment.
It should be ok, it’s an optional field, so WS or EVS should not break until we update them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.