You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why: Critical correctness issue. Arc::clone requires a reference (&shutdown_flag) but the PR incorrectly uses the owned value, causing compilation errors.
High
Add TLS support
The reqwest crate with default features disabled but without specifying a TLS implementation will not be able to make HTTPS requests. Add the rustls-tls feature to enable secure connections.
-reqwest = { version = "^0.12", default-features = false, features = ["json", "multipart"] }+reqwest = { version = "^0.12", default-features = false, features = ["json", "multipart", "rustls-tls"] }
[To ensure code accuracy, apply this suggestion manually]
Suggestion importance[1-10]: 8
__
Why: Significant functional issue. Disabling default features without adding rustls-tls will prevent HTTPS requests from working, breaking API functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
PR Type
Enhancement, Tests
Description
Add API and SDK support for updating user account preferences
UpdateAccountPreferenceRequestschema in OpenAPI and SDKs/api/v1/account/preferencesendpoint in OpenAPI, Python, Rust, and TypeScript SDKsEnhance Rust SDK and examples for new preferences API
Improve Python and TypeScript SDKs for account preferences
UpdateAccountPreferenceRequestin Python SDKMinor dependency and formatting updates
Changes walkthrough 📝
11 files
Add UpdateAccountPreferenceRequest schema and PUT endpointAdd update account preferences interface and API methodAdd async put_account_preferences API methodAdd UpdateAccountPreferenceRequest modelSupport additional properties in AccountPreferenceExport UpdateAccountPreferenceRequest modelExport UpdateAccountPreferenceRequest in modelsAdd put_account_preferences API function and error typeAdd UpdateAccountPreferenceRequest structExport UpdateAccountPreferenceRequest modelAdd example for updating and retrieving preferences8 files
Document putAccountPreferences endpoint usageAdd UpdateAccountPreferenceRequest model documentationDocument put_account_preferences endpointAdd UpdateAccountPreferenceRequest model docDocument new API and model in SDK READMEDocument put_account_preferences endpointAdd UpdateAccountPreferenceRequest model docDocument new API and model in crate README4 files
Register UpdateAccountPreferenceRequest model docRegister new model and test filesRegister new model doc and source filesUpdate openapi-generator-cli version to 7.13.01 files
Add test for UpdateAccountPreferenceRequest model2 files
Update reqwest dependency featuresBump bluefin_api version and add reqwest dependency1 files
Fix clippy warnings and add main function19 files
Fix import ordering for clippyFix import ordering for clippyFix argument formatting and import orderFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyFix import ordering for clippyRemove trailing whitespace and fix formattingFix import ordering for clippyFix import ordering for clippy