updated open api specs for affiliate rewards#122
Merged
NidaKarimAli merged 4 commits intomainfrom Jun 11, 2025
Merged
Conversation
kevin-ip
reviewed
Jun 11, 2025
kevin-ip
reviewed
Jun 11, 2025
kevin-ip
reviewed
Jun 11, 2025
Comment on lines
+1009
to
+1011
| type: integer | ||
| description: Cashback amount to give to the referees | ||
| example: 10 |
Contributor
There was a problem hiding this comment.
will it ever be a decimal?
| default: "totalEarnings" | ||
| - name: sortOrder | ||
| in: query | ||
| required: false |
Contributor
There was a problem hiding this comment.
Should we define the default sortOrder?
Contributor
Author
There was a problem hiding this comment.
We have it handled on the service side, if not given we'll keep it descending
Contributor
There was a problem hiding this comment.
Nice, it would be great to document here so that the caller is aware of the default value.
kevin-ip
approved these changes
Jun 11, 2025
Contributor
kevin-ip
left a comment
kevin-ip
left a comment
There was a problem hiding this comment.
Friendly reminder to generate the client code and test with the examples in this repo before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andrecastelo could you please generate all 3 SDKs from the latest open-api specs while I figure out version issues on my end.