Skip to content

Update ts oapi config#29

Merged
kevin-ip merged 1 commit intomainfrom
kevin/update-ts-oapi-config
Mar 14, 2025
Merged

Update ts oapi config#29
kevin-ip merged 1 commit intomainfrom
kevin/update-ts-oapi-config

Conversation

@kevin-ip
Copy link
Copy Markdown
Contributor

making sure the openapi-generator pick up the properties

Before in main, no code change happens if I update it to generate with snake case:

Screenshot 2025-03-14 at 11 22 41 AM

After the config update:

Screenshot 2025-03-14 at 11 46 03 AM

We now have variables in snake case:
Screenshot 2025-03-14 at 11 45 41 AM

making sure the openapi-generator pick up the properties
@kevin-ip kevin-ip requested a review from a team March 14, 2025 16:52
Copy link
Copy Markdown
Contributor

@alawrenc alawrenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! So we've just been getting lucky that the currently defined additional_properties happen to be the defaults?

@kevin-ip
Copy link
Copy Markdown
Contributor Author

kevin-ip commented Mar 14, 2025

Yikes! So we've just been getting lucky that the currently defined additional_properties happen to be the defaults?

@alawrenc
Think we are lucky. We should revisit it in the future to remove the defaults and some irrelevant ones, e.g. preferInterface

@kevin-ip kevin-ip merged commit 7af9aa4 into main Mar 14, 2025
@kevin-ip kevin-ip deleted the kevin/update-ts-oapi-config branch March 14, 2025 17:09
kevin-ip added a commit that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants