[BFP-1194] Merge multiple TradingFees into one object#35
Merged
Conversation
kevin-ip
force-pushed
the
kevin/BFP-1194-fix-overlapping-names
branch
2 times, most recently
from
fe0d896 to
db376f7
Compare
kevin-ip
changed the title
Since account-data-api.yaml and websocket-api.yaml both defined with TradingFee with identical schema, openapi codegen generates the client code with TradingFee and TradingFee1. Let's merge the two into one object.
merging the two defined in exchange-api (EVS) and account-data-api (ADS): * (ADS) tradeId -> id * (EVS) timeAtMillis -> executedAtMillis
and the following enums: * PositionSideEnm * TradeSideEnum * TradeTypeEnum * TransactionTypeEnum
so that ADS service would not run into name collision
kevin-ip
force-pushed
the
kevin/BFP-1194-fix-overlapping-names
branch
from
2ae3f7a to
f7fed60
Compare
alawrenc
approved these changes
Mar 20, 2025
Contributor
alawrenc
left a comment
alawrenc
left a comment
There was a problem hiding this comment.
This is definitely better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since OpenAPI YAML files define identical schemas and enums,
OpenAPI Codegen generates client code with overlapping names, such as Asset and Asset1.
Let's merge them into one.
EVS:
Rename EVS Asset -> AssetConfig
Hoist the following to common.yaml:
enums:
objects: