Fix/datetime utcnow deprecation#140
Open
Acuspeedster wants to merge 4 commits intofireform-core:mainfrom
Open
Conversation
…emplate tests with detailed assertions and mock setups
…uce API calls and improve performance
…utc) datetime.utcnow() is deprecated since Python 3.12 and will be removed in a future release. It returns a naive datetime with no timezone info, which can cause silent bugs in comparisons. Replace both default_factory calls in Template and FormSubmission with a private _utcnow() helper that returns a timezone-aware UTC datetime via datetime.now(timezone.utc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139
Summary
Replaces deprecated
datetime.utcnow()with timezone-awaredatetime.now(timezone.utc)in ORM models.Problem
datetime.utcnow()deprecated in Python 3.12Solution
Using a named helper keeps default_factory serializable and explicit.
Impact