fix: filename generation with pathlib.stem instead of hardcoded [:-4]#273
Open
ishansurdi wants to merge 1 commit intofireform-core:mainfrom
Open
fix: filename generation with pathlib.stem instead of hardcoded [:-4]#273ishansurdi wants to merge 1 commit intofireform-core:mainfrom
ishansurdi wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247
Changed the filename generation in
src/filler.pyto usePath().steminstead of slicing off the last 4 characters with[:-4].The old approach broke with files like
document.pdf.backuporcontract_2024(no extension). Now it properly handles any filename pattern and prevents name collisions.Works correctly now whether you're processing
.pdf,.pdf.backup, or files without extensions.