Share eslintrc

[jasonLaster]

we want the individual tools to share eslint configs

we can have a base config that they pull in like dev-server or use eslints extends api

 // Extend from the shared list of defined globals for mochitests.
  "extends": "../../../../../.eslintrc.mochitests.js"

[juliandescottes]

We are hitting a somewhat related issue with the inspector: the SublimeLinter plugin for Sublime picks up the the eslint binary that gets installed in devtools/client/inspector/node_modules (which comes from launchpad having eslint has a dependency instead of a devDependency)

This binary is missing mozilla specific rules, so linting in Sublime is broken at the moment for users who npm install'd the inspector.

I realize this is really an edge case, and probably more an issue with the plugin than with launchpad. But if we end up removing eslint from the dependencies of launchpad that would be great.

I can imagine us having a devtools-linting module that would have eslint as dependency + the default eslintrc file. And then other modules could depend on devtools-linting as a dev-dependency, if that makes sense.

[jasonLaster]

It does. I think that might happen more in other areas to where the launchpad pulls on other packages and is an opinionated solution

…

On Thu, Jan 26, 2017 at 6:55 AM Julian Descottes ***@***.***> wrote: We are hitting a somewhat related issue with the inspector: the SublimeLinter plugin for Sublime picks up the the eslint binary that gets installed in devtools/client/inspector/node_modules (which comes from launchpad having eslint has a dependency instead of a devDependency) This binary is missing mozilla specific rules, so linting in Sublime is broken at the moment for users who npm install'd the inspector. I realize this is really an edge case, and probably more an issue with the plugin than with launchpad. But if we end up removing eslint from the dependencies of launchpad that would be great. I can imagine us having a devtools-linting module that would have eslint as dependency + the default eslintrc file. And then other modules could depend on devtools-linting as a dev-dependency, if that makes sense. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#92 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPiYvPuxB6QnV7V-FtsLoM2kHtNk9bMks5rWIm0gaJpZM4Ll2Me> .