bump source map worker #672
Conversation
tromey
left a comment
tromey
left a comment
There was a problem hiding this comment.
Thank you. This is good.
What do you think of an RFC proposing that pure version bumps do not need review?
It's fine with me. I don't think there's a particular need to land every release into M-C; just ones that we need or ones where we think there are issues to solve first, where the original author is better situated to solve them. |
|
Agreed on both accounts.
…On Wed, Sep 13, 2017 at 4:52 PM Tom Tromey ***@***.***> wrote:
Would it be alright if i updated mc when I update the debugger? the two
should be in sync
It's fine with me. I don't think there's a particular need to land every
release into M-C; just ones that we need or ones where we think there are
issues to solve first, where the original author is better situated to
solve them.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#672 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPiYtWe9HKWMy0m4FoR4ICE7Spoqgk3ks5siECLgaJpZM4PWsZL>
.
|
It's a tough call. It puts more pressure on releasing debugger bundles. The goal of landing a release in m-c is to actually validate the release: check that it doesn't break any mochitest etc... Let's say we skip several sourcemaps releases without checking in m-c. Then we try to update the debugger bundle in m-c, we also need to update the sourcemaps bundle. What if this breaks stuff in m-c? Then you need to go back and fix sourcemaps, update the debugger again etc... Our goal right now should be to make the bundle updating process easier (and automate it!). I think allowing sourcemaps (or reps for that matter) releases to be published on npm without having been validated on m-c would go in the opposite direction. And as it just happens, the latest update of the debugger forgot to include the new sourcemaps bundle :) |
3 participants
this bumps the source map worker.
Would it be alright if i updated mc when I update the debugger? the two should be in sync