This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Conversation
This was caused because we used Object.assign which calls setters and stripped the __proto__ property. Fixes #986.
janodvarko
approved these changes
Mar 8, 2018
Contributor
janodvarko
left a comment
janodvarko
left a comment
There was a problem hiding this comment.
Looks good for me.
R+ assuming tests are green
Thanks,
Honza
Member
Author
|
Mhh, circle does not like the spread operator |
Member
Author
|
yay, circle's happy with correct Node version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As found by @Loirooriol , this fix an issue with objects containing a
__proto__property (Object.assigncalls setters and strips the proto property).Took this as an opportunity to remove
Object.assigncalls where it could be done.Fixes #986.