Skip to content

Address review comments

c92a1ba
Select commit
Loading
Failed to load commit list.
Merged

Update dhat convertor to work better with valgrind #5269

Address review comments
c92a1ba
Select commit
Loading
Failed to load commit list.
firefoxci-taskcluster / Decision Task succeeded Jan 2, 2025 in 1m 4s

FirefoxCI (pull_request)

The task that creates all of the other tasks in the task graph

Details

View task in Taskcluster | View logs in Taskcluster | View task group in Taskcluster

Task Status

Started: 2025-01-02T12:26:40.375Z
Resolved: 2025-01-02T12:27:12.181Z
Task Execution Time: 31 seconds, 806 milliseconds
Task Status: completed
Reason Resolved: completed
RunId: 0

Artifacts

- public/actions.json
- public/docker-contexts/linux.tar.gz
- public/fetch-content
- public/full-task-graph.json
- public/label-to-taskid.json
- public/logs/live_backing.log
- public/logs/live.log
- public/parameters.yml
- public/runnable-jobs.json
- public/run-task
- public/target-tasks.json
- public/task-graph.json


[taskcluster 2025-01-02 12:26:40.496Z] Task ID: BZG7kSO2Qd-SlxPhoMLGqg
[taskcluster 2025-01-02 12:26:40.497Z] Worker ID: 7819644580086365022
[taskcluster 2025-01-02 12:26:40.497Z] Worker Group: us-central1-f
[taskcluster 2025-01-02 12:26:40.497Z] Worker Node Type: projects/887720501152/machineTypes/n2-standard-2
[taskcluster 2025-01-02 12:26:40.497Z] Worker Pool: mozilla-1/decision-gcp
[taskcluster 2025-01-02 12:26:40.497Z] Worker Version: 38.0.5
[taskcluster 2025-01-02 12:26:40.497Z] Public IP: 34.29.107.7
[taskcluster 2025-01-02 12:26:40.497Z] Hostname: mozilla-1-decision-gcp-pb85isawsogiympmzqswug
[taskcluster 2025-01-02 12:26:40.497Z] using cache "mozilla-level-1-checkouts-sparse-v2" -> /builds/worker/checkouts

4d32b49e2995 - Started downloading
16a31e38bed1 - Started downloading
4d32b49e2995 - Downloaded in 0.255 seconds
16a31e38bed1 - Downloaded in 0.704 seconds
Digest: sha256:7518c410bdf91142b0e26455d26ddaf861202cfbb3c35d0b1ef85d1ed577a5bd
Status: Downloaded newer image for mozillareleases/taskgraph@sha256:7518c410bdf91142b0e26455d26ddaf861202cfbb3c35d0b1ef85d1ed577a5bd
[taskcluster 2025-01-02 12:26:51.182Z] === Task Starting ===
[setup 2025-01-02T12:26:51.749Z] run-task started in /
[vcs 2025-01-02T12:26:51.752Z] WARNING: vcs checkout path (/builds/worker/checkouts/src) not in cache or volume; performance will likely suffer
[setup 2025-01-02T12:26:51.752Z] running as worker:worker
[vcs 2025-01-02T12:26:51.753Z] executing ['git', 'clone', 'https://github.com/firefox-devtools/profiler', '/builds/worker/checkouts/src']
[vcs 2025-01-02T12:26:51.758Z] Cloning into '/builds/worker/checkouts/src'...
[vcs 2025-01-02T12:27:01.271Z] executing ['git', 'fetch', '--tags', 'https://github.com/gregtatum/perf.html', 'dhat-valgrind']
[vcs 2025-01-02T12:27:02.449Z] From https://github.com/gregtatum/perf.html
[vcs 2025-01-02T12:27:02.449Z]  * branch              dhat-valgrind -> FETCH_HEAD
[vcs 2025-01-02T12:27:02.455Z] executing ['git', 'checkout', '-f', 'c92a1bad1009b230af6e655eff8e5e24e8e32078']
[vcs 2025-01-02T12:27:02.756Z] Note: switching to 'c92a1bad1009b230af6e655eff8e5e24e8e32078'.
[vcs 2025-01-02T12:27:02.757Z] 
[vcs 2025-01-02T12:27:02.757Z] You are in 'detached HEAD' state. You can look around, make experimental
[vcs 2025-01-02T12:27:02.758Z] changes and commit them, and you can discard any commits you make in this
[vcs 2025-01-02T12:27:02.758Z] state without impacting any branches by switching back to a branch.
[vcs 2025-01-02T12:27:02.758Z] 
[vcs 2025-01-02T12:27:02.758Z] If you want to create a new branch to retain commits you create, you may
[vcs 2025-01-02T12:27:02.758Z] do so (now or later) by using -c with the switch command. Example:
[vcs 2025-01-02T12:27:02.758Z] 
[vcs 2025-01-02T12:27:02.759Z]   git switch -c <new-branch-name>
[vcs 2025-01-02T12:27:02.759Z] 
[vcs 2025-01-02T12:27:02.759Z] Or undo this operation with:
[vcs 2025-01-02T12:27:02.759Z] 
[vcs 2025-01-02T12:27:02.759Z]   git switch -
[vcs 2025-01-02T12:27:02.759Z] 
[vcs 2025-01-02T12:27:02.759Z] Turn off this advice by setting config variable advice.detachedHead to false
[vcs 2025-01-02T12:27:02.759Z] 
[vcs 2025-01-02T12:27:02.759Z] HEAD is now at c92a1bad Address review comments
[vcs 2025-01-02T12:27:02.759Z] executing ['git', 'clean', '-xdff']
[vcs 2025-01-02T12:27:02.767Z] TinderboxPrint:<a href='https://github.com/gregtatum/perf.html/commit/c92a1bad1009b230af6e655eff8e5e24e8e32078' title='Built from perf.html commit c92a1bad1009b230af6e655eff8e5e24e8e32078'>c92a1bad1009b230af6e655eff8e5e24e8e32078</a>
[pip-install 2025-01-02T12:27:02.768Z] executing ['/usr/bin/python3', '-mpip', 'install', '--require-hashes', '-r', '/builds/worker/checkouts/src/taskcluster/requirements.txt']
[pip-install 2025-01-02T12:27:03.462Z] Defaulting to user installation because normal site-packages is not writeable
[pip-install 2025-01-02T12:27:03.543Z] Requirement already satisfied: appdirs==1.4.4 in /usr/local/lib/python3.8/dist-packages (from -r /builds/worker/checkouts/src/taskcluster/requirements.txt (line 7)) (1.4.4)
[pip-install 2025-01-02T12:27:03.656Z] Collecting arrow==1.2.3
[pip-install 2025-01-02T12:27:03.704Z]   Downloading arrow-1.2.3-py3-none-any.whl (66 kB)
[pip-install 2025-01-02T12:27:03.743Z] Collecting binaryornot==0.4.4
[pip-install 2025-01-02T12:27:03.758Z]   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
[pip-install 2025-01-02T12:27:03.827Z] Collecting certifi==2024.7.4
[pip-install 2025-01-02T12:27:03.842Z]   Downloading certifi-2024.7.4-py3-none-any.whl (162 kB)
[pip-install 2025-01-02T12:27:03.883Z] Collecting chardet==5.2.0
[pip-install 2025-01-02T12:27:03.897Z]   Downloading chardet-5.2.0-py3-none-any.whl (199 kB)
[pip-install 2025-01-02T12:27:04.304Z] Collecting charset-normalizer==3.2.0
[pip-install 2025-01-02T12:27:04.319Z]   Downloading charset_normalizer-3.2.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (199 kB)
[pip-install 2025-01-02T12:27:04.381Z] Collecting click==8.1.7
[pip-install 2025-01-02T12:27:04.395Z]   Downloading click-8.1.7-py3-none-any.whl (97 kB)
[pip-install 2025-01-02T12:27:04.440Z] Collecting cookiecutter==2.3.0
[pip-install 2025-01-02T12:27:04.454Z]   Downloading cookiecutter-2.3.0-py3-none-any.whl (39 kB)
[pip-install 2025-01-02T12:27:04.480Z] Collecting giturlparse==0.11.1
[pip-install 2025-01-02T12:27:04.495Z]   Downloading giturlparse-0.11.1-py2.py3-none-any.whl (15 kB)
[pip-install 2025-01-02T12:27:04.536Z] Collecting idna==3.7
[pip-install 2025-01-02T12:27:04.550Z]   Downloading idna-3.7-py3-none-any.whl (66 kB)
[pip-install 2025-01-02T12:27:04.600Z] Collecting jinja2==3.1.4
[pip-install 2025-01-02T12:27:04.615Z]   Downloading jinja2-3.1.4-py3-none-any.whl (133 kB)
[pip-install 2025-01-02T12:27:04.672Z] Collecting json-e==4.5.3
[pip-install 2025-01-02T12:27:04.687Z]   Downloading json_e-4.5.3-py3-none-any.whl (13 kB)
[pip-install 2025-01-02T12:27:04.740Z] Collecting markdown-it-py==3.0.0
[pip-install 2025-01-02T12:27:04.754Z]   Downloading markdown_it_py-3.0.0-py3-none-any.whl (87 kB)
[pip-install 2025-01-02T12:27:05.038Z] Collecting markupsafe==2.1.3
[pip-install 2025-01-02T12:27:05.054Z]   Downloading MarkupSafe-2.1.3-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (25 kB)
[pip-install 2025-01-02T12:27:05.078Z] Collecting mdurl==0.1.2
[pip-install 2025-01-02T12:27:05.093Z]   Downloading mdurl-0.1.2-py3-none-any.whl (10.0 kB)
[pip-install 2025-01-02T12:27:05.132Z] Collecting mozilla-repo-urls==0.1.1
[pip-install 2025-01-02T12:27:05.147Z]   Downloading mozilla_repo_urls-0.1.1-py3-none-any.whl (6.2 kB)
[pip-install 2025-01-02T12:27:05.214Z] Collecting pygments==2.16.1
[pip-install 2025-01-02T12:27:05.228Z]   Downloading Pygments-2.16.1-py3-none-any.whl (1.2 MB)
[pip-install 2025-01-02T12:27:05.295Z] Collecting python-dateutil==2.8.2
[pip-install 2025-01-02T12:27:05.310Z]   Downloading python_dateutil-2.8.2-py2.py3-none-any.whl (247 kB)
[pip-install 2025-01-02T12:27:05.355Z] Collecting python-slugify==8.0.1
[pip-install 2025-01-02T12:27:05.370Z]   Downloading python_slugify-8.0.1-py2.py3-none-any.whl (9.7 kB)
[pip-install 2025-01-02T12:27:05.549Z] Collecting pyyaml==6.0.1
[pip-install 2025-01-02T12:27:05.564Z]   Downloading PyYAML-6.0.1-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (736 kB)
[pip-install 2025-01-02T12:27:05.579Z] Requirement already satisfied: redo==2.0.4 in /usr/local/lib/python3.8/dist-packages (from -r /builds/worker/checkouts/src/taskcluster/requirements.txt (line 248)) (2.0.4)
[pip-install 2025-01-02T12:27:05.661Z] Collecting requests==2.32.0
[pip-install 2025-01-02T12:27:05.678Z]   Downloading requests-2.32.0-py3-none-any.whl (63 kB)
[pip-install 2025-01-02T12:27:05.684Z] Requirement already satisfied: requests-unixsocket==0.3.0 in /usr/local/lib/python3.8/dist-packages (from -r /builds/worker/checkouts/src/taskcluster/requirements.txt (line 259)) (0.3.0)
[pip-install 2025-01-02T12:27:05.864Z] Collecting rich==13.5.2
[pip-install 2025-01-02T12:27:05.880Z]   Downloading rich-13.5.2-py3-none-any.whl (239 kB)
[pip-install 2025-01-02T12:27:05.919Z] Collecting six==1.16.0
[pip-install 2025-01-02T12:27:05.933Z]   Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
[pip-install 2025-01-02T12:27:05.936Z] Requirement already satisfied: slugid==2.0.0 in /usr/local/lib/python3.8/dist-packages (from -r /builds/worker/checkouts/src/taskcluster/requirements.txt (line 271)) (2.0.0)
[pip-install 2025-01-02T12:27:06.026Z] Collecting taskcluster-taskgraph==6.2.0
[pip-install 2025-01-02T12:27:06.042Z]   Downloading taskcluster_taskgraph-6.2.0-py3-none-any.whl (187 kB)
[pip-install 2025-01-02T12:27:06.049Z] Requirement already satisfied: taskcluster-urls==13.0.1 in /usr/local/lib/python3.8/dist-packages (from -r /builds/worker/checkouts/src/taskcluster/requirements.txt (line 279)) (13.0.1)
[pip-install 2025-01-02T12:27:06.070Z] Collecting text-unidecode==1.3
[pip-install 2025-01-02T12:27:06.085Z]   Downloading text_unidecode-1.3-py2.py3-none-any.whl (78 kB)
[pip-install 2025-01-02T12:27:06.138Z] Collecting typing-extensions==4.7.1
[pip-install 2025-01-02T12:27:06.152Z]   Downloading typing_extensions-4.7.1-py3-none-any.whl (33 kB)
[pip-install 2025-01-02T12:27:06.267Z] Collecting urllib3==2.2.2
[pip-install 2025-01-02T12:27:06.282Z]   Downloading urllib3-2.2.2-py3-none-any.whl (121 kB)
[pip-install 2025-01-02T12:27:06.320Z] Collecting voluptuous==0.13.1
[pip-install 2025-01-02T12:27:06.335Z]   Downloading voluptuous-0.13.1-py3-none-any.whl (29 kB)
[pip-install 2025-01-02T12:27:06.597Z] WARNING: The candidate selected for download or install is a yanked version: 'requests' candidate (version 2.32.0 at https://files.pythonhosted.org/packages/24/e8/09e8d662a9675a4e4f5dd7a8e6127b463a091d2703ed931a64aa66d00065/requests-2.32.0-py3-none-any.whl#sha256=f2c3881dddb70d056c5bd7600a4fae312b2a300e39be6a118d30b90bd27262b5 (from https://pypi.org/simple/requests/) (requires-python:>=3.8))
[pip-install 2025-01-02T12:27:06.597Z] Reason for being yanked: Yanked due to conflicts with CVE-2024-35195 mitigation
[pip-install 2025-01-02T12:27:06.731Z] Installing collected packages: six, mdurl, urllib3, typing-extensions, text-unidecode, python-dateutil, pygments, markupsafe, markdown-it-py, idna, charset-normalizer, chardet, certifi, rich, requests, pyyaml, python-slugify, jinja2, giturlparse, click, binaryornot, arrow, voluptuous, mozilla-repo-urls, json-e, cookiecutter, taskcluster-taskgraph
[pip-install 2025-01-02T12:27:07.456Z]   WARNING: The script pygmentize is installed in '/builds/worker/.local/bin' which is not on PATH.
[pip-install 2025-01-02T12:27:07.456Z]   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
[pip-install 2025-01-02T12:27:07.532Z]   WARNING: The script markdown-it is installed in '/builds/worker/.local/bin' which is not on PATH.
[pip-install 2025-01-02T12:27:07.532Z]   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
[pip-install 2025-01-02T12:27:07.656Z]   WARNING: The script normalizer is installed in '/builds/worker/.local/bin' which is not on PATH.
[pip-install 2025-01-02T12:27:07.656Z]   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
[pip-install 2025-01-02T12:27:07.826Z]   WARNING: The script chardetect is installed in '/builds/worker/.local/bin' which is not on PATH.
[pip-install 2025-01-02T12:27:07.827Z]   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
[pip-install 2025-01-02T12:27:08.092Z]   WARNING: The script slugify is installed in '/builds/worker/.local/bin' which is not on PATH.
[pip-install 2025-01-02T12:27:08.092Z]   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
[pip-install 2025-01-02T12:27:08.362Z]   WARNING: The script cookiecutter is installed in '/builds/worker/.local/bin' which is not on PATH.
[pip-install 2025-01-02T12:27:08.363Z]   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
[pip-install 2025-01-02T12:27:08.461Z]   WARNING: The script taskgraph is installed in '/builds/worker/.local/bin' which is not on PATH.
[pip-install 2025-01-02T12:27:08.462Z]   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
[pip-install 2025-01-02T12:27:08.474Z] Successfully installed arrow-1.2.3 binaryornot-0.4.4 certifi-2024.7.4 chardet-5.2.0 charset-normalizer-3.2.0 click-8.1.7 cookiecutter-2.3.0 giturlparse-0.11.1 idna-3.7 jinja2-3.1.4 json-e-4.5.3 markdown-it-py-3.0.0 markupsafe-2.1.3 mdurl-0.1.2 mozilla-repo-urls-0.1.1 pygments-2.16.1 python-dateutil-2.8.2 python-slugify-8.0.1 pyyaml-6.0.1 requests-2.32.0 rich-13.5.2 six-1.16.0 taskcluster-taskgraph-6.2.0 text-unidecode-1.3 typing-extensions-4.7.1 urllib3-2.2.2 voluptuous-0.13.1
[pip-install 2025-01-02T12:27:08.633Z] WARNING: You are using pip version 21.1.3; however, version 24.3.1 is available.
[pip-install 2025-01-02T12:27:08.635Z] You should consider upgrading via the '/usr/bin/python3 -m pip install --upgrade pip' command.
[task 2025-01-02T12:27:08.725Z] executing ['bash', '-cx', "cd /builds/worker/checkouts/src && ln -s /builds/worker/artifacts artifacts && ~/.local/bin/taskgraph decision --pushlog-id='0' --pushdate='0' --project='firefox-profiler' --owner='gregtatum@users.noreply.github.com' --level='1' --repository-type=git --tasks-for='github-pull-request' --base-repository='https://github.com/firefox-devtools/profiler' --base-ref='main' --base-rev='b86c7c55f74f1b88bb0ee719b3d16fa1d3196742' --head-repository='https://github.com/gregtatum/perf.html' --head-ref='dhat-valgrind' --head-rev='c92a1bad1009b230af6e655eff8e5e24e8e32078' \n"]
[task 2025-01-02T12:27:08.728Z] + cd /builds/worker/checkouts/src
[task 2025-01-02T12:27:08.729Z] + ln -s /builds/worker/artifacts artifacts
[task 2025-01-02T12:27:08.730Z] + /builds/worker/.local/bin/taskgraph decision --pushlog-id=0 --pushdate=0 --project=firefox-profiler --owner=gregtatum@users.noreply.github.com --level=1 --repository-type=git --tasks-for=github-pull-request --base-repository=https://github.com/firefox-devtools/profiler --base-ref=main --base-rev=b86c7c55f74f1b88bb0ee719b3d16fa1d3196742 --head-repository=https://github.com/gregtatum/perf.html --head-ref=dhat-valgrind --head-rev=c92a1bad1009b230af6e655eff8e5e24e8e32078
[task 2025-01-02T12:27:08.972Z] 2025-01-02 12:27:08,972 - INFO - Loading graph configuration.
[task 2025-01-02T12:27:08.984Z] 2025-01-02 12:27:08,984 - WARNING - using default project parameters; add firefox-profiler to PER_PROJECT_PARAMETERS in /builds/worker/.local/lib/python3.8/site-packages/taskgraph/decision.py to customize behavior for this project
[task 2025-01-02T12:27:08.985Z] 2025-01-02 12:27:08,985 - INFO - Using Parameters(id=43fdc874cabb) (from defaults)
[task 2025-01-02T12:27:08.986Z] 2025-01-02 12:27:08,986 - INFO - writing artifact file `parameters.yml`
[task 2025-01-02T12:27:08.993Z] 2025-01-02 12:27:08,993 - INFO - writing artifact file `actions.json`
[task 2025-01-02T12:27:08.995Z] 2025-01-02 12:27:08,995 - INFO - Loading kinds
[task 2025-01-02T12:27:08.998Z] 2025-01-02 12:27:08,998 - INFO - Generating full task set
[task 2025-01-02T12:27:09.009Z] 2025-01-02 12:27:09,009 - INFO - Writing docker-contexts/linux.tar.gz for docker image linux
[task 2025-01-02T12:27:09.027Z] 2025-01-02 12:27:09,026 - INFO - Generated 1 tasks for kind docker-image
[task 2025-01-02T12:27:09.037Z] 2025-01-02 12:27:09,037 - INFO - Generated 1 tasks for kind hello
[task 2025-01-02T12:27:09.038Z] 2025-01-02 12:27:09,037 - INFO - Generating full task graph
[task 2025-01-02T12:27:09.039Z] 2025-01-02 12:27:09,038 - INFO - Full task graph contains 2 tasks and 1 dependencies
[task 2025-01-02T12:27:09.040Z] 2025-01-02 12:27:09,038 - INFO - writing artifact file `full-task-graph.json`
[task 2025-01-02T12:27:09.041Z] 2025-01-02 12:27:09,039 - INFO - writing artifact file `runnable-jobs.json`
[task 2025-01-02T12:27:09.042Z] 2025-01-02 12:27:09,040 - INFO - Generating target task set
[task 2025-01-02T12:27:09.043Z] 2025-01-02 12:27:09,040 - INFO - Filter filter_target_tasks pruned 1 tasks (1 remain)
[task 2025-01-02T12:27:09.044Z] 2025-01-02 12:27:09,040 - INFO - writing artifact file `target-tasks.json`
[task 2025-01-02T12:27:09.045Z] 2025-01-02 12:27:09,040 - INFO - Generating target task graph
[task 2025-01-02T12:27:09.046Z] 2025-01-02 12:27:09,040 - INFO - Adding 1 tasks with `always_target` attribute
[task 2025-01-02T12:27:09.046Z] 2025-01-02 12:27:09,040 - INFO - Generating optimized task graph
[task 2025-01-02T12:27:09.046Z] 2025-01-02 12:27:09,041 - INFO - No tasks removed during optimization
[task 2025-01-02T12:27:09.151Z] 2025-01-02 12:27:09,150 - INFO - No tasks replaced during optimization
[task 2025-01-02T12:27:09.151Z] 2025-01-02 12:27:09,151 - INFO - writing artifact file `task-graph.json`
[task 2025-01-02T12:27:09.152Z] 2025-01-02 12:27:09,152 - INFO - writing artifact file `label-to-taskid.json`
[task 2025-01-02T12:27:09.154Z] 2025-01-02 12:27:09,154 - INFO - Creating task with taskId IRK1mG9JRTKuJZadPI3aNw for build-docker-image-linux
[task 2025-01-02T12:27:09.277Z] 2025-01-02 12:27:09,277 - INFO - Creating task with taskId ZxRC6b_tRmiUjkkRWTj67w for hello-world
[taskcluster 2025-01-02 12:27:09.794Z] === Task Finished ===
[taskcluster 2025-01-02 12:27:11.700Z] Successful task run with exit code: 0 completed in 31.205 seconds