Add an importer for the text format taken as input by flamegraph.pl. #5359
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5359 +/- ##
==========================================
- Coverage 85.66% 85.66% -0.01%
==========================================
Files 313 313
Lines 30982 30985 +3
Branches 8515 8519 +4
==========================================
+ Hits 26541 26543 +2
- Misses 4011 4012 +1
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
force-pushed
the
import-flamegraph
branch
from
67aff3c to
f48e0e0
Compare
|
I updated the code, rebased it after the TS migration and added some tests. Let me know what you think! |
| while (count-- > 0) { | ||
| addSample(timeStamp++, stack); | ||
| } |
There was a problem hiding this comment.
huh, why not make use of the frame weight?
There was a problem hiding this comment.
I tried that too, but our activity graph's weight support is really not great, that's why I didn't really like it that much.
Without individual samples, every different stack looks like just 1 sample, even if its weight was 1000. So it really looks disproportionate and you really don't see the stacks with lots of weight that easily by just clicking around on the timeline.
There was a problem hiding this comment.
Makes sense! There's a proposal in #4101 (comment) for what we could do here.
There was a problem hiding this comment.
Ah thanks! Yes, that would be great to improve.
Changes: [Markus Stange] Use a longer test timeout when debugging with VS code. (#5679) [Markus Stange] Move Jest config from package.json to jest.config.js (#5680) [Markus Stange] Make binary profile format parsing use Uint8Array instead of ArrayBuffer (#5678) [Markus Stange] Use workbox-cli to generate the service worker (#5681) [Nazım Can Altınova] Migrate from Appveyor to GitHub Actions Windows runners (#5660) [Nazım Can Altınova] Remove some unused dependencies (#5696) [Nazım Can Altınova] Update the document links and sections (#5705) [Nazım Can Altınova] Clear selected and expanded call node paths on browser back button if it removes transforms (#5701) [Nazım Can Altınova] Properly type the Map and Set objects (#5623) [Valentin Gosu] Add priorityHeader field to network requests (#5707) [Nazım Can Altınova] Redirect unpublished url loads to the homepage similar to from-file (#5712) [Florian Quèze/Nazım Can Altınova] Add an importer for the text format taken as input by flamegraph.pl. (#5359) [Florian Quèze] Improve the import of profiles generated from clang -ftime-trace=file.json (#5714) [Markus Stange] Move React stuff out of marker schema logic module. (#5720) And thanks to our localizers: en-CA: chutten en-CA: Paul es-CL: ravmn fr: Théo Chevalier fur: Fabio Tomat ru: berry tr: Selim Şumlu zh-CN: Olvcpr423 zh-CN: wxie
3 participants
gradle-profiler can generate these profiles when using the async-profiler format or the jfr format.
Example imported profiles for the async-profiler format and for the jfr format.