Skip to content

Conversation

@mstange
Copy link
Contributor

@mstange mstange commented Sep 4, 2025

I don't actually notice a difference but this seems cleaner.

I kept the file, to make it slightly easier to experiment with adding stuff there. But I'm also happy to remove it if you ask me to.

Nevermind, I'm removing the entire file because prettier would want it to be formatted as {}.

@mstange mstange requested a review from canova September 4, 2025 22:01
@mstange mstange force-pushed the vscode-settings-cleanup branch from c3327d7 to 98081b6 Compare September 4, 2025 22:04
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.81%. Comparing base (f6db0d3) to head (98081b6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5601   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files         309      309           
  Lines       30371    30371           
  Branches     8362     8362           
=======================================
  Hits        26063    26063           
  Misses       3887     3887           
  Partials      421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange merged commit 3ddc098 into firefox-devtools:main Sep 5, 2025
15 checks passed
@canova canova mentioned this pull request Sep 5, 2025
canova added a commit that referenced this pull request Sep 5, 2025
Changes:

[Markus Stange] Some path fixes (#5581)
[depfu[bot]] Update all Yarn dependencies (2025-09-03) (#5585)
[Nazım Can Altınova] Remove the findDOMNode usage from ContextMenu
(#5588)
[Markus Stange] Replace @fetch-mock/jest with plain fetch-mock (#5575)
[Ryan Hunt] Replace zee-worker.js with compression streams API (#5584)
[Markus Stange] Remove unused FilterNavigatorBar animations (#5591)
[Markus Stange] Use different ports for start-prod and start-examples
(#5592)
[Markus Stange] Remove SharedArrayBuffer workaround (#5596)
[Jeff Muizelaar] Make time after responseEnd have a more accurate name
(#5582)
[Ryan Hunt] Move compression and decompression to a worker (#5597)
[Markus Stange] Remove Flow and no-TypeScript settings from
.vscode/settings.json (#5601)
[Markus Stange] Simplify the eslint command in package.json so that
eslint.config.mjs is the only place you need to look if you want to know
if a file is being checked (#5600)
[Markus Stange] Fix search filtering (#5599)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (September 5, 2025) (#5603)

And thanks to our localizers:

de: mstange
tr: Fernando Javier
tr: Rua
tr: Selim Şumlu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants