Reduce allocations for getStackLineInfo + getStackAddressInfo#5761
Merged
mstange merged 1 commit intofirefox-devtools:mainfrom Mar 3, 2026
Merged
Reduce allocations for getStackLineInfo + getStackAddressInfo#5761mstange merged 1 commit intofirefox-devtools:mainfrom
mstange merged 1 commit intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5761 +/- ##
==========================================
+ Coverage 85.36% 85.41% +0.04%
==========================================
Files 320 321 +1
Lines 31916 32037 +121
Branches 8780 8728 -52
==========================================
+ Hits 27246 27365 +119
- Misses 4239 4241 +2
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
force-pushed
the
compact-stack-line-info
branch
4 times, most recently
from
d446334 to
5858c75
Compare
mstange
force-pushed
the
compact-stack-line-info
branch
3 times, most recently
from
0dc54ef to
d9058d2
Compare
mstange
force-pushed
the
compact-stack-line-info
branch
4 times, most recently
from
b9e9cfd to
bdda4d2
Compare
canova
approved these changes
Mar 3, 2026
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
It's impressive to lower the memory usage that much, nice idea to use something like trie! It took me some time to read it understand it completely but I believe I do now 😄
I added a few nits for comments etc., nothing blocking.
Before: https://share.firefox.dev/3NnthpO After: https://share.firefox.dev/45dMNv1 getStackLineInfo now allocates 46MB instead of 220MB (4.8x reduction), and takes 146ms instead of 338ms (2.3x reduction), when opening the source view for mozjemalloc.cpp on https://share.firefox.dev/3NnzEcF
mstange
force-pushed
the
compact-stack-line-info
branch
from
bdda4d2 to
0740f14
Compare
Merged
canova
added a commit
that referenced
this pull request
Mar 3, 2026
Changes: [fatadel] Fix crash when nativeSymbol index is out of bounds in assembly view (#5850) [depfu[bot]] Update all Yarn dependencies (2026-02-25) (#5859) [Nazım Can Altınova] Fix the color of dark mode back arrow svg (#5863) [fatadel] Force canvas redraw when system theme changes (#5861) [Nazım Can Altınova] Fix unhandled promise rejection in setupInitialUrlState (#5864) [fatadel] Persist selected marker in URL and show sticky tooltip on load (#5847) [Markus Stange] Implement the "collapse resource" transform with the help of the "collapse direct recursion" transform. (#5824) [Markus Stange] Bump rollup from 2.79.2 to 2.80.0 (#5868) [Markus Stange] Remove async attribute from module script tag. (#5870) [Nazım Can Altınova] Update the docsify package that's used in the user documentation (#5872) [Markus Stange] Share stackTable, frameTable, funcTable, resourceTable and nativeSymbols between threads (#5482) [Nazım Can Altınova] Escape CSS URLs that are coming from profiles (#5874) [fatadel] Update home page message for the other browser case (#5866) [fatadel] Add support for ternaries in marker labels (#5857) [Markus Stange] Reduce allocations for getStackLineInfo + getStackAddressInfo (#5761) And special thanks to our localizers: de: Ger fy-NL: Fjoerfoks it: Francesco Lodolo [:flod] nl: Fjoerfoks ru: berry ru: Valery Ledovskoy zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview
On large profiles, opening the source view can cause large allocations because we create
Setobjects for many stacks. In this PR I've experimented with a more compact storage of a collection of sets.Before: https://share.firefox.dev/3NnthpO
After: https://share.firefox.dev/45dMNv1
getStackLineInfonow allocates 46MB instead of 220MB (4.8x reduction), and takes 146ms instead of 338ms (2.3x reduction), when opening the source view formozjemalloc.cppon https://share.firefox.dev/3NnzEcF.