Deploy January 27, 2026 #5787
Merged
Deploy January 27, 2026 #5787
+71,015
−94,163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: berry <igory.ygr200@gmail.com> (ru)
Co-authored-by: berry <igory.ygr200@gmail.com> (ru)
Co-authored-by: wxie <xiewensheng@hotmail.com> (zh-CN)
Co-authored-by: Fabio Tomat <dark.tmtfx@gmail.com> (fur)
String tables are now profile-wide instead of thread-local.
…utton tests (#5718) Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Pin-guang Chen <petercpg@mail.moztw.org> (zh-TW)
Co-authored-by: Francesco Lodolo [:flod] <flod+pontoon@mozilla.com> (it)
Co-authored-by: Ian Neal <iann_bugzilla@blueyonder.co.uk> (en-GB)
Co-authored-by: Ger <ger_a@web.de> (de)
Co-authored-by: Pin-guang Chen <petercpg@mail.moztw.org> (zh-TW)
Co-authored-by: Melo46 <melo@carmu.com> (ia)
Co-authored-by: Fjoerfoks <fryskefirefox@gmail.com> (nl)
Co-authored-by: Fjoerfoks <fryskefirefox@gmail.com> (fy-NL)
Co-authored-by: ravmn <ravmn@ravmn.cl> (es-CL)
Co-authored-by: Valery Ledovskoy <valery@ledovskoy.com> (ru)
Co-authored-by: Valery Ledovskoy <valery@ledovskoy.com> (ru)
Co-authored-by: Marcelo Ghelman <marcelo.ghelman@gmail.com> (pt-BR)
* improve a11y of appendage column * improve a11y of label frames
Co-authored-by: Théo Chevalier <theo@theochevalier.org> (fr)
I noticed that webpack was still including the gz worker in the generated symbolicator-cli bundle. And esbuild was even putting it in a separate file. But we don't need the gz worker in the symbolicator-cli bundle; symbolicator-cli targets node so we really just want to run the node version of gz.ts. This PR makes the "node" version the default behaviour of gz.ts, and then adds a browser override via the package.json "browser" mapping to use the worker version. In our tests we want to use the worker version though, because we want to test what happens in a browser environment. So we use a custom jest-resolver.js. I tried to use `browser-resolve` ([as suggested in the Jest docs](https://jestjs.io/docs/configuration#resolver-string)) in it but it ended up resolving some ESM dependencies like valibot to their mjs variant instead of their CJS variant and broke the tests, so I kept a manual implementation instead. I didn't dig very deep. With this change, the symbolicator-cli bundle no longer contains the gz worker code.
…ss timings (#5770) This PR makes it so that we don't allocate lots of one-element sets just to compute which line number to scroll to, when a call node is double-clicked.
We discussed that we would like to have a different switch, but to be able to deploy the current patches so far, removing the current UI. After the previous commit, we can now toggle the dark mode from the devtools console.
It looks like this is the remnants of the previous implementation that was reverted.
While talking with Markus, we decided to hide this dark mode checkbox for now, and move the toggle to the devtools console. This will allow us to deploy the frontend sooner than later. You can use `window.toggleDarkMode()` to toggle the dark mode. The follow-up would be to: - Use the system default for the dark/light mode. - Have a toggle to switch between system/light/dark. [Main branch](https://main--perf-html.netlify.app/) / [deploy preview](https://deploy-preview-5783--perf-html.netlify.app/)
Updated locales: be, de, el, en-CA, en-GB, es-CL, fr, fur, fy-NL, ia, it, nl, pt-BR, ru, sv-SE, tr, zh-CN, zh-TW.
Fixes #5715. This PR does three things: 1. Puts the category properly to the marker categories. 2. Removes the dummy payload if the event doesn't have any data. 3. Removes beginEventDetail all together with all the logic around it. It's a relatively small PR, but test changes make it look bigger. Example chrome profile: [Trace-20251212T152428.json.zip](https://github.com/user-attachments/files/24131844/Trace-20251212T152428.json.zip) [Before](https://share.firefox.dev/4iXjORN) / [after](https://deploy-preview-5717--perf-html.netlify.app/public/8b0g1a7q0epejdp1wmgva4dkrq4yxs16kef7d68/marker-chart/?globalTrackOrder=50w4&hiddenGlobalTracks=2w4&hiddenLocalTracksByPid=37886-0wf~37888-0wc~37758-0w5~37767-0w2~0-0&thread=0&timelineType=category&v=12) It looks like the chrome categories include commas, but this way still looked like an improvement to me.
This transform avoids the need to drop callees manually if you want to see a flame graph for a single JS function but no other JS functions; with this transform, you can focus on the function's self while you're in the JS-only view, and then go back to the combined view to see any native functions involved in the execution of that JS function.
[Deploy preview](https://deploy-preview-5774--perf-html.netlify.app/public/vehb8pdke1sphpc41g6cyfp4jm06c266vqt7910/flame-graph/?globalTrackOrder=0b859674a132&hiddenGlobalTracks=0wa&hiddenLocalTracksByPid=45850-0w2~45860-0~45856-0~45853-0~51863-0~45859-0~50753-0~51865-0~45855-0~50550-01~45854-0w2~45862-01&implementation=js&thread=i&transforms=mf-431&v=12) This transform avoids the need to drop callees manually if you want to see a flame graph for a single JS function but no other JS functions. With this transform, you can focus on the function's self while you're in the JS-only view, and then go back to the combined view to see any native functions involved in the execution of that JS function. For example, in [this profile](https://deploy-preview-5774--perf-html.netlify.app/public/vehb8pdke1sphpc41g6cyfp4jm06c266vqt7910/flame-graph/?globalTrackOrder=0b859674a132&hiddenGlobalTracks=0wa&hiddenLocalTracksByPid=45850-0w2~45860-0~45856-0~45853-0~51863-0~45859-0~50753-0~51865-0~45855-0~50550-01~45854-0w2~45862-01&implementation=js&thread=i&transforms=mf-431&v=12), you can "focus self" on `HTMLElement.click`, and then change the implementation filter to "All Frames". This will show you the overhead on the way to calling the click handler, minus the time spent in the called JS code ([profile](https://deploy-preview-5774--perf-html.netlify.app/public/vehb8pdke1sphpc41g6cyfp4jm06c266vqt7910/flame-graph/?globalTrackOrder=0b859674a132&hiddenGlobalTracks=0wa&hiddenLocalTracksByPid=45850-0w2~45860-0~45856-0~45853-0~51863-0~45859-0~50753-0~51865-0~45855-0~50550-01~45854-0w2~45862-01&thread=i&transforms=mf-431~ffs-js-2168&v=13)). If you had just done "focus function" on `HTMLElement.click`, you would have seen all the time spent in callees too ([profile](https://deploy-preview-5774--perf-html.netlify.app/public/vehb8pdke1sphpc41g6cyfp4jm06c266vqt7910/flame-graph/?globalTrackOrder=0b859674a132&hiddenGlobalTracks=0wa&hiddenLocalTracksByPid=45850-0w2~45860-0~45856-0~45853-0~51863-0~45859-0~50753-0~51865-0~45855-0~50550-01~45854-0w2~45862-01&thread=i&transforms=mf-431~ff-2168&v=13)), and you would have needed to drop each JS callee manually. <img width="1318" height="984" alt="Screenshot 2026-01-22 at 4 29 47 PM" src="https://github.com/user-attachments/assets/1fc10764-4841-494e-9a25-7fc14a1ba36f" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of exciting changes 🎉:
[arai-a] Put radio buttons into labels (#5738)
[DaniPopes] Update comment for "unique-string" (#5741)
[Karan Pradhan] Hide tooltip filter button in non-sticky tooltips and add hideFilterButton tests (#5718)
[arai-a] Add a menu to copy the Marker Table as text (#5732)
[arai-a] Make the entire list item clickable for the "Full Range" (#5742)
[Markus Stange] Move symbol table demangling out of SymbolStore into SymbolProvider (#5746)
[Markus Stange] Remove SVG asset imports from profile-data.ts (#5747)
[arai-a] Do not apply sticky tooltip on double click (#5754)
[arai-a] Skip the ChartCanvas redraw on the Viewport's internal default state usage (#5744)
[Markus Stange] Stop blindly extracting uint8array.buffer after calling compress() (#5753)
[Markus Stange] In the assembly view state, refer to the current symbol by index (#5755)
[Markus Stange] Fix "scroll to hotspot" functionality in the source view + assembly view (#5759)
[Markus Stange] Keep the colorField markerSchema field when processing profiles in the gecko format (#5760)
[Markus Stange] Implement dark mode (#5740)
[Markus Stange] Fix light-mode colors (#5765)
[Markus Stange] Tweak dark mode colours. (#5767)
[Nazım Can Altınova] Enable some basic type-aware lints (#5775)
[Markus Stange] Allow seeing different assembly code for the same function (#5349)
[fatadel] Refine tree view a11y (#5779)
[fatadel] Align double-click behavior of stack chart with flame graph (#5782)
[Markus Stange] Split gz.ts properly into node and browser variants (#5764)
[Markus Stange] Simplify and optimize the computation of per-call-node line and address timings (#5770)
[Nazım Can Altınova] Move the dark mode toggle to devtools console (#5783)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (Jan 27, 2026) (#5785)
[Nazım Can Altınova] Improve Chrome importer marker payload logic (#5717)
[Markus Stange] Add a Focus Self transform (#5774)
[Nazım Can Altınova] Enable the Turkish locale in production (#5786)
And huge thanks to our localizers 🎉 :
be: Mikalai Udodau
de: Ger
de: Michael Köhler
el: Jim Spentzos
en-CA: chutten
en-CA: Saurabh
en-GB: Ian Neal
en-GB: Saurabh
es-CL: ravmn
fy-NL, nl: Fjoerfoks
fr: Skywarp
fr: Théo Chevalier
fur: Fabio Tomat
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Fjoerfoks
nl: Mark Heijl
pt-BR: Marcelo Ghelman
ru: berry
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
tr: Grk
zh-CN: Olvcpr423
zh-CN: wxie
zh-TW: Pin-guang Chen