add comment for uptime label translation#5806
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5806 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 319 319
Lines 31343 31343
Branches 8546 8546
=======================================
Hits 26846 26846
Misses 4066 4066
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
locales/en-US/app.ftl
Outdated
| MenuButtons--metaInfo--buffer-duration-unlimited = Unlimited | ||
| MenuButtons--metaInfo--application = Application | ||
| MenuButtons--metaInfo--name-and-version = Name and version: | ||
| # Indicates time since startup (NOT related to availability) |
There was a problem hiding this comment.
Let's be even more precise:
| # Indicates time since startup (NOT related to availability) | |
| # The time between application startup and when the profile was captured |
(or is it between application startup and when the profiler was started?)
locales/en-US/app.ftl
Outdated
| MenuButtons--metaInfo--application = Application | ||
| MenuButtons--metaInfo--name-and-version = Name and version: | ||
| MenuButtons--metaInfo--application-uptime = Uptime: | ||
| # The time between Firefox startup and when the profiler was started |
There was a problem hiding this comment.
Well, the app is usually Firefox but doesn't have to be, given how many other profilers export to our format. That's why I had written "application" in my suggestion. But it's probably fine to just say Firefox here.
There was a problem hiding this comment.
I was confused with "application" thinking to myself "the application -> Firefox Profiler but we mean just Firefox here" but I completely missed that not only Firefox uses the profiler...
There was a problem hiding this comment.
@mstange do you want me to revert to "application" ?
There was a problem hiding this comment.
I've changed to "application". Let's make it ideal ;)
Changes: [Nazım Can Altınova] Make the range duration text white again (#5792) [Alex Thayer] Display traced values in Stack Chart view (#5363) [Nazım Can Altınova] Improve the JS traced arguments visualization in call node tooltips (#5795) [Markus Stange] Make the argument-values.json profile fixture go through profile upgrading (#5796) [Markus Stange] Add thread.usedInnerWindowIDs to the processed profile format (#5780) [fatadel] Fix context menu and hover preview z-index (#5797) [fatadel] add TrackPower--tooltip-power-microwatt (#5799) [Markus Stange] Two small test fixes (#5801) [fatadel] fix selected thread pid color in light mode (#5805) [Markus Stange] Some fixes to the profile merging code (#5802) [fatadel] fix disabled button color in dark mode (#5808) [fatadel] add comment for uptime label translation (#5806) [Nazım Can Altınova] Add a theme toggle to the home page and follow the system theme by default (#5800) [Nazım Can Altınova] 🔃 Sync: l10n -> main (Feb 4, 2025) (#5813) And huge thanks to our localizers: de: Ger de: Michael Köhler de: Nazım Can Altınova el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Andreas Pettersson tr: Selim Şumlu zh-TW: Pin-guang Chen
3 participants
Closes #5777.