Skip to content

Comments

Tweak dark mode colors some more.#5846

Merged
canova merged 2 commits intofirefox-devtools:mainfrom
mstange:more-dark-theme-tweaks
Feb 17, 2026
Merged

Tweak dark mode colors some more.#5846
canova merged 2 commits intofirefox-devtools:mainfrom
mstange:more-dark-theme-tweaks

Conversation

@mstange
Copy link
Contributor

@mstange mstange commented Feb 17, 2026

Main branch | Deploy preview

The --lowered-background-color was a bit too dark for my taste.

I'm also tweaking the before-startup / after-shutdown colors in the timeline.

Before:
Screenshot 2026-02-16 at 8 22 50 PM

After:
Screenshot 2026-02-16 at 8 22 31 PM

@mstange mstange requested a review from canova February 17, 2026 01:25
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.56%. Comparing base (c0b82be) to head (3e56f67).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5846   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         319      319           
  Lines       31411    31411           
  Branches     8670     8660   -10     
=======================================
  Hits        26876    26876           
  Misses       4104     4104           
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange force-pushed the more-dark-theme-tweaks branch from dc63c83 to 07b6916 Compare February 17, 2026 01:28
Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@canova canova enabled auto-merge (squash) February 17, 2026 09:00
@canova canova merged commit dbff9e7 into firefox-devtools:main Feb 17, 2026
19 checks passed
@canova canova mentioned this pull request Feb 24, 2026
canova added a commit that referenced this pull request Feb 24, 2026
Changes:

[Markus Stange] Move transparent fill check to a less expensive place.
(#5826)
[fatadel] refine docs for ctrl key (#5831)
[Nazım Can Altınova] Update the team members inside CONTRIBUTING.md
(#5829)
[fatadel] Provide correct instructions on the home page for Firefox for
Android (Fenix) (#5816)
[Markus Stange] Make markers darker (#5839)
[Markus Stange] Directly use photon-colors (#5821)
[Markus Stange] Migrate to esbuild (#5589)
[Markus Stange] Use data URLs for SVG files. (#5845)
[Markus Stange] Tweak dark mode colors some more. (#5846)
[Nazım Can Altınova] Make the source table non-optional in the gecko
profile format (#5842)
[fatadel] fix foreground color of the button on error page (#5849)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (February 24, 2026) (#5855)

And special thanks to our localizers:

de: Michael Köhler
el: Jim Spentzos
en-GB: Ian Neal
es-CL: ravmn
fr: Théo Chevalier
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Mark Heijl
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants