Make profiler-edit run profile compacting before writing out the file#6015
Merged
Merged
Conversation
89e2948 to
9816c0e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6015 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 328 328
Lines 34254 34255 +1
Branches 9479 9574 +95
=======================================
+ Hits 28712 28713 +1
Misses 5114 5114
Partials 428 428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
profiler-editwas just writing out the profile withJSON.stringify, which is different from what the front-end does when you download the profile - the front-end goes through profile sanitization, which also runs compacting.You can see in the snapshot tests that running compacting removes some unused strings from the stringArray.