Skip to content

Make profiler-edit run profile compacting before writing out the file#6015

Merged
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:profiler-edit-compact
May 11, 2026
Merged

Make profiler-edit run profile compacting before writing out the file#6015
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:profiler-edit-compact

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented May 11, 2026

profiler-edit was just writing out the profile with JSON.stringify, which is different from what the front-end does when you download the profile - the front-end goes through profile sanitization, which also runs compacting.

You can see in the snapshot tests that running compacting removes some unused strings from the stringArray.

@mstange mstange requested a review from canova May 11, 2026 19:27
@mstange mstange force-pushed the profiler-edit-compact branch from 89e2948 to 9816c0e Compare May 11, 2026 19:27
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.82%. Comparing base (fede2a3) to head (9816c0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6015   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files         328      328           
  Lines       34254    34255    +1     
  Branches     9479     9574   +95     
=======================================
+ Hits        28712    28713    +1     
  Misses       5114     5114           
  Partials      428      428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@mstange mstange merged commit 6aa05e4 into firefox-devtools:main May 11, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants