Skip to content

[BHP1-1533] Fix Table Shading Filters Across all Result Tables#218

Merged
Kcheung42 merged 2 commits intomainfrom
kc-BHP1-1553-fix-shading-filters-across-all-matrices
May 4, 2026
Merged

[BHP1-1533] Fix Table Shading Filters Across all Result Tables#218
Kcheung42 merged 2 commits intomainfrom
kc-BHP1-1553-fix-shading-filters-across-all-matrices

Conversation

@Kcheung42
Copy link
Copy Markdown
Collaborator

@Kcheung42 Kcheung42 commented Apr 22, 2026


Purpose

Non directional output matrices were not being shaded like the directional outputs

  • Solution Move the computation of the set of cell coordinates to shade to outside of construct-matrices and compute across all output data
  • Also fix table shading icons showing up even when no settings were enabled.

Related Issues

Closes BHP1-1533

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Open this worksheet:
    BHP1-1553.zip

  2. Navigate to results

  3. See that currently there are no shading icons

  4. Navigate to run's settings page and toggle on some table shading filters and change some of the min/max values

  5. Navigate to results page and ensure shading icons are now visible and that all matrices have the same cells shaded. (Before this, Fire Perimeter was not being properly shaded)

Screenshots

@rjsheperd
Copy link
Copy Markdown
Contributor

Nice work pulling out that logic!

projects/behave/src/cljs/behave/components/results/matrices.cljs

L104, 107, 118, 124, 127 - What are your thoughts on creating a map-utils function that handles the filter and first in one go? Maybe something like select?

Screenshots

Screenshot 2026-04-29 at 10 20 19 AM Screenshot 2026-04-29 at 10 20 25 AM

@Kcheung42
Copy link
Copy Markdown
Collaborator Author

L104, 107, 118, 124, 127 - What are your thoughts on creating a map-utils function that handles the filter and first in one go? Maybe something like select?

addressed in #213

@rjsheperd
Copy link
Copy Markdown
Contributor

LGTM 👍

@Kcheung42 Kcheung42 merged commit 334c38c into main May 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants