Add config to pass RUSTLER_NIF_VERSION to Cross#26
Merged
akrousset merged 1 commit intofirezone:mainfrom Jun 28, 2022
Merged
Conversation
This change is necessary in order to use the correct version of NIF for the target that is being built with `cross`. By default, `cross` won´t pass down the env vars from the host machine. See philss/rustler_precompiled#23 for further details.
Member
|
Thanks for the PR! LGTM but will wait for @akrousset 's approval. |
akrousset
approved these changes
Jun 28, 2022
Contributor
akrousset
left a comment
akrousset
left a comment
There was a problem hiding this comment.
Thanks for the heads up and PR! This is good to go 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is necessary in order to use the correct version of NIF for
the target that is being built with
cross.By default,
crosswon´t pass down the env vars from the host machine.See philss/rustler_precompiled#23 for further details.