Fixed off-by-one bug in setFirmwareNameAndVersion() where we were writin... #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting a zero terminator past the end of the block we'd gotten from malloc().
soundanalogous
added a commit
that referenced
this pull request
Feb 7, 2015
Fixed off-by-one bug in setFirmwareNameAndVersion() where we were writin...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...g a zero terminator past the end of the block we'd gotten from malloc().
Since the next line writes a zero to the firmwareVersionCount byte of firmwareVersionVector, we need to ask for one more than that bytes from malloc() so that we have enough space. Without the "+1", you write past the end of the array, which doesn't play nice with some malloc implementations (PIC32/chipKIT being one).