Skip to content

Make VERSION_BLINK_PIN optional #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make VERSION_BLINK_PIN optional #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Firmata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ void FirmataClass::printVersion(void)
void FirmataClass::blinkVersion(void)
{
// flash the pin with the protocol version
pinMode(VERSION_BLINK_PIN, OUTPUT);
strobeBlinkPin(FIRMATA_MAJOR_VERSION, 40, 210);
delay(250);
strobeBlinkPin(FIRMATA_MINOR_VERSION, 40, 210);
Expand Down Expand Up @@ -454,6 +453,7 @@ void FirmataClass::systemReset(void)

// =============================================================================
// used for flashing the pin for the version number
#if defined(VERSION_BLINK_PIN)
void FirmataClass::strobeBlinkPin(int count, int onInterval, int offInterval)
{
byte i;
Expand All @@ -465,6 +465,11 @@ void FirmataClass::strobeBlinkPin(int count, int onInterval, int offInterval)
digitalWrite(VERSION_BLINK_PIN, LOW);
}
}
#else
void FirmataClass::strobeBlinkPin(int, int, int)
{
}
#endif


// make one instance for the user to use
Expand Down