Skip to content

Bump version to v0.14.15.0#1674

Merged
justanwar merged 1 commit intomasterfrom
v0141500
Oct 19, 2025
Merged

Bump version to v0.14.15.0#1674
justanwar merged 1 commit intomasterfrom
v0141500

Conversation

@justanwar
Copy link
Copy Markdown
Member

@justanwar justanwar commented Sep 23, 2025

Changing our build system to Cmake requires changing a different file for version bump.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 23, 2025

Walkthrough

Bumped client version metadata in build/config scripts: CLIENT_VERSION_REVISION changed from 14 to 15 and CLIENT_VERSION_BUILD reset from 3 to 0, resulting in project version 0.14.15.

Changes

Cohort / File(s) Summary of Changes
Version bump
CMakeLists.txt, configure.ac
Incremented client revision (CLIENT_VERSION_REVISION) from 1415 and reset build number (CLIENT_VERSION_BUILD) from 30; updates composed project version to 0.14.15.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • psolstice
  • ajaydono
  • levonpetrosyan93

Poem

I hop through the build, a rabbit with glee,
Revision climbs up—now fifteen, whee!
Build number rests, a soft little zero,
Tags in the meadow, release like a hero. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description does not follow the repository’s required template because it lacks the “## PR intention” and “## Code changes brief” sections, and it only provides a single sentence that does not clearly outline the intent, scope, or context of the version bump. Please update the description to include a “## PR intention” section that explains what this PR is intended to do and why (e.g., syncing the version bump in CMake after switching build systems), and a “## Code changes brief” section summarizing any non-obvious architectural or UX impacts of the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Bump version to v0.14.15.0” directly reflects the primary change in this pull request, namely updating the project version from 0.14.14.3 to 0.14.15.0 across the CMake and configure scripts, and it is concise and specific without extraneous information.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v0141500

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2a0e1f and a23823b.

📒 Files selected for processing (2)
  • CMakeLists.txt (1 hunks)
  • configure.ac (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
  • GitHub Check: build-guix-x86_64-apple-darwin
  • GitHub Check: build-mac-cmake
  • GitHub Check: build-guix-x86_64-w64-mingw32
  • GitHub Check: build-guix-arm64-apple-darwin
  • GitHub Check: build-linux-cmake
  • GitHub Check: build-guix-aarch64-linux-gnu
  • GitHub Check: build-guix-x86_64-linux-gnu
  • GitHub Check: Create Source Distribution
  • GitHub Check: build-windows-cmake
  • GitHub Check: build-mac-cmake
  • GitHub Check: build-guix-x86_64-w64-mingw32
  • GitHub Check: build-guix-x86_64-apple-darwin
  • GitHub Check: Create Source Distribution
  • GitHub Check: build-guix-arm64-apple-darwin
  • GitHub Check: build-guix-x86_64-linux-gnu
  • GitHub Check: build-windows-cmake
  • GitHub Check: build-guix-aarch64-linux-gnu
  • GitHub Check: build-linux-cmake
🔇 Additional comments (2)
configure.ac (1)

5-6: Version bump looks correct.

The version components have been updated appropriately:

  • Revision incremented from 14 to 15
  • Build reset to 0

This produces version 0.14.15.0 and aligns with the PR objective.

CMakeLists.txt (1)

22-23: Version bump is consistent across build systems.

The CMake version components have been updated to match configure.ac:

  • Revision incremented from 14 to 15
  • Build reset to 0

Both Autotools and CMake build systems will now produce version 0.14.15.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/clientversion.h (1)

29-29: Optional: sync fallback COPYRIGHT_YEAR with configure.

When building without config/bitcoin-config.h, this fallback still prints 2021. Consider bumping to 2025 to match configure.ac.

Apply:

-#define COPYRIGHT_YEAR 2021
+#define COPYRIGHT_YEAR 2025
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cda6aa and afb1b5e.

📒 Files selected for processing (2)
  • configure.ac (1 hunks)
  • src/clientversion.h (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: build-guix-x86_64-apple-darwin
  • GitHub Check: build-guix-x86_64-linux-gnu
  • GitHub Check: build-guix-x86_64-w64-mingw32
  • GitHub Check: build-guix-aarch64-linux-gnu
  • GitHub Check: build-guix-arm64-apple-darwin
  • GitHub Check: Create Source Distribution
  • GitHub Check: build-windows-cmake
  • GitHub Check: build-linux-cmake
  • GitHub Check: build-mac-cmake
🔇 Additional comments (2)
configure.ac (1)

5-6: Autotools version macros updated — LGTM.
configure.ac and src/clientversion.h both define CLIENT_VERSION as 0.14.15.0 (MAJOR=0, MINOR=14, REVISION=15, BUILD=0).

src/clientversion.h (1)

19-20: Version bump to 0.14.15.0 — LGTM.
Header and configure.ac match; computed CLIENT_VERSION = 141500.

@justanwar justanwar merged commit 82e0001 into master Oct 19, 2025
43 of 51 checks passed
@justanwar justanwar deleted the v0141500 branch October 19, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants