Conversation
WalkthroughBumped client version metadata in build/config scripts: CLIENT_VERSION_REVISION changed from 14 to 15 and CLIENT_VERSION_BUILD reset from 3 to 0, resulting in project version 0.14.15. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/clientversion.h (1)
29-29: Optional: sync fallback COPYRIGHT_YEAR with configure.When building without config/bitcoin-config.h, this fallback still prints 2021. Consider bumping to 2025 to match configure.ac.
Apply:
-#define COPYRIGHT_YEAR 2021 +#define COPYRIGHT_YEAR 2025
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
configure.ac(1 hunks)src/clientversion.h(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: build-guix-x86_64-apple-darwin
- GitHub Check: build-guix-x86_64-linux-gnu
- GitHub Check: build-guix-x86_64-w64-mingw32
- GitHub Check: build-guix-aarch64-linux-gnu
- GitHub Check: build-guix-arm64-apple-darwin
- GitHub Check: Create Source Distribution
- GitHub Check: build-windows-cmake
- GitHub Check: build-linux-cmake
- GitHub Check: build-mac-cmake
🔇 Additional comments (2)
configure.ac (1)
5-6: Autotools version macros updated — LGTM.
configure.ac and src/clientversion.h both define CLIENT_VERSION as 0.14.15.0 (MAJOR=0, MINOR=14, REVISION=15, BUILD=0).src/clientversion.h (1)
19-20: Version bump to 0.14.15.0 — LGTM.
Header and configure.ac match; computed CLIENT_VERSION = 141500.
Changing our build system to Cmake requires changing a different file for version bump.