Scripts and tools: test Dockerfile on linux/amd64 and linux/arm64#1834
Scripts and tools: test Dockerfile on linux/amd64 and linux/arm64#1834TaprootFreak wants to merge 2 commits into
Conversation
The Dockerfile already cross-builds for the host architecture via the
depends/ system (uname -m -> {x86_64,aarch64}-linux-gnu). This extends
the existing single-platform Dockerfile test to a buildx matrix that
verifies both linux/amd64 and linux/arm64 build cleanly on every PR
that touches Dockerfile or depends/, so an arm64 regression cannot
slip in unnoticed.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Can you pin the image: |
Pin tonistiigi/binfmt to its current manifest digest to prevent supply-chain attacks via a compromised :latest tag. refs firoorg#1834
|
CodeAnt AI is reviewing your PR. |
|
Done — pinned |
|
CodeAnt AI finished reviewing your PR. |
User description
Summary
Extends the existing Dockerfile build test to a buildx matrix covering both
linux/amd64andlinux/arm64.Why
The Dockerfile already cross-builds for the host architecture via the
depends/system —uname -mresolves tox86_64-linux-gnuoraarch64-linux-gnu, both of which are listed in thedepends/Makefile. The single-platform CI test masks any future change that would silently break arm64 (Apple Silicon hosts, AWS Graviton, Raspberry Pi 4/5).Change
.github/workflows/test-dockerfile.yml: matrix on[linux/amd64, linux/arm64], builds viadocker buildxonubuntu-latest. arm64 leg uses QEMU.depends/**or the workflow file itself changes.Test plan
linux/amd64,linux/arm64) greenubuntu-24.04-armrunners later)CodeAnt-AI Description
Test the Dockerfile on both amd64 and arm64
What Changed
linux/amd64andlinux/arm64depends/change, not just the Dockerfile itselfImpact
✅ Fewer arm64 build regressions✅ Safer Dockerfile checks in CI✅ Earlier detection of dependency-related build failures🔄 Retrigger CodeAnt AI Review
Details
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.