Fail when fetching CurseForge versions

[Calboot]

I was uploading my own mod to CurseForge using this plugin in Github Workflow runs when I get these:

Therefore the plugin failed to validate game versions

I wonder if it could be solved using Objects.equals()

[hypherionmc]

Um, that's not a code bug. That is CurseForge not responding to the api request 🤔

Do you happen to be in russia maybe?

[Calboot]

actually i'm located in China mainland

but this error occurs when running a github workflow, so i suppose it's not a regional problem?

[hypherionmc]

You're right. After I sent the message I snapped that you said GitHub actions.

Can you maybe provide me with the full output of the publish task, and is there some where I can see how you configured it?

[Calboot]

logs_37097786078.zip

And the plugin's configured like:

publisher {
    apiKeys {
        modrinth System.getProperty("MODRINTH_TOKEN") ?: "unset"
        curseforge System.getProperty("CURSEFORGE_TOKEN") ?: "unset"
    }

    setDebug(true)

    setCurseID("1220026")
    setModrinthID("hGOHBiok")

    setVersionType("release")
    setChangelog("See github releases for more information")

    setVersion(fullProjectVersion)
    setGameVersions(project.minecraft_version)
    setLoaders("fabric")

    setArtifact(tasks.remapJar)

    if (mcVersion < 11700) {
        setJavaVersions([JavaVersion.VERSION_1_8])
    }

    curseDepends {
        required "fabric-api", "carpet"
        optional "carpet-tis-addition", "guglecarpetaddition"
    }

    modrinthDepends {
        required "fabric-api", "carpet"
        optional "carpet-tis-addition", "gca"
    }
}

"fullProjectVersion" is defined before this block

[hypherionmc]

Thanks. I'll take a proper look at this when I'm at my pc a bit later today. Still at work ATM

[hypherionmc]

Okay.

Swap our maven url from https://maven.firstdark.dev/releases to https://maven.firstdark.dev/snapshots and then try with version 2.1.7+snapshot.2.

You can test locally by enabling debug mode, and running the curseforge publish task. If it still has issues, it would fail there as well, and if it works, it won't publish anything.

If this does work, I'll push out a release

[Calboot]

Well it doesn't complain about the error before, but is says:

That's pretty much confusing...

Should I use previous versions of the plugins for now?

[hypherionmc]

Error 400. Hmmmm that's interesting, cause literally the only input data that request handles, is your API key.

If you "hardcode" (meaning place the raw API key) into the curseforge API key field, does it return the same error?

[Calboot]

Hard to test as it returns 403 when using proxy in China mainland, but definitely not 400

[hypherionmc]

403 is a clue actually. That means, you are not allowed to access the API (which is usually caused by an invalid API key).

400 is bad request (aka invalid data was sent to the request), but 403 means unauthorized, which is the error code they use for invalid API keys

[Calboot]

I'll just re-generate a key and try it again

[hypherionmc]

From which page are you generating the API keys? Just asking, because CF has two different types of API keys

[Calboot]

https://legacy.curseforge.com/account/api-tokens

This shouldn't be a problem as I've been using this for a long time with CurseGradle (and I switched to this because that one was deprecated)

[hypherionmc]

Okay that is the correct one. Just double checking.

If you still get the 403 error, I'll have to involve curse, cause this sounds very similar to #24