Skip to content

Support JavaVersion in setJavaVersion#9

Merged
hypherionmc merged 1 commit intofirstdarkdev:2.0from
MattSturgeon:java-version
Mar 27, 2024
Merged

Support JavaVersion in setJavaVersion#9
hypherionmc merged 1 commit intofirstdarkdev:2.0from
MattSturgeon:java-version

Conversation

@MattSturgeon
Copy link
Copy Markdown
Contributor

@MattSturgeon MattSturgeon commented Mar 26, 2024

As discussed in this comment

  • update javadoc
  • update README
  • add unit test update integration test

Closes #4

Maintain support for "curseforge" format Java versions, e.g. "Java 8".
@MattSturgeon
Copy link
Copy Markdown
Contributor Author

MattSturgeon commented Mar 27, 2024

I've updated the testprojects, but I can't find any TestKit tests that use them...

I've updated the example in the README, let me know if you'd prefer a different example.

Copy link
Copy Markdown
Member

@hypherionmc hypherionmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me :)

@hypherionmc hypherionmc merged commit 4a2e05f into firstdarkdev:2.0 Mar 27, 2024
@MattSturgeon MattSturgeon deleted the java-version branch March 27, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Define supported Java versions for CurseForge uploads

2 participants