Fix empty AICHAT_API_KEY fallback in integration specs#57
Merged
raghubetina merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
In integration API key tests, treats empty strings as present and skips fallback. Use explicit empty checks before falling back to OPENAI_API_KEY for custom env-var and direct api_key test setup. This aligns test setup with runtime behavior and addresses the PR #56 review finding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in the integration test setup introduced in PR #56.
The previous test setup used:
ENV["AICHAT_API_KEY"] || ENV["OPENAI_API_KEY"]In Ruby, an empty string is truthy, so when
AICHAT_API_KEY="", testswould incorrectly use the empty key instead of falling back.
What changed
spec/integration/ai_chat_integration_spec.rbAPI key setup totreat empty
AICHAT_API_KEYas missing before fallback.CUSTOM_OPENAI_KEYassignment)api_key:test setupWhy
This aligns integration test setup with runtime behavior, where empty
AICHAT_API_KEYshould fall back toOPENAI_API_KEY.Verification
bundle exec standardrb spec/integration/ai_chat_integration_spec.rbbundle exec rspec spec/integration/ai_chat_integration_spec.rb:227Both passed locally.