Compact JS Widget approach#19
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4312b0e664
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| initializer "dev_toolbar.importmap", before: "importmap" do |app| | ||
| if defined?(Importmap) | ||
| app.config.importmap.paths << root.join("config/importmap.rb") |
There was a problem hiding this comment.
When this gem is built from the current gemspec, only lib/**/* and app/**/* are packaged, so the newly added config/importmap.rb is absent from released gems. In an installed app this line points importmap-rails at a non-existent file, so the automatic dev_toolbar pin is never loaded and the README's import "dev_toolbar" fails for consumers relying on the new automatic pin; the package needs to include this config file or define the pin from a packaged location.
Useful? React with 👍 / 👎.
|
Not going with this approach, see: #18 (comment) |
1 participant
Testing on this repo in an active codespace: https://github.com/appdev-projects/oscar-party-3-forms