chore(release): drop windows-x64 + fix macOS rolldown native binding#137
Merged
Conversation
v0.6.6 tag pushed but release.yml failed 3/4 platforms: - windows-x64 ✗ libc::SIGKILL doesn't exist on Windows libc (POSIX-only API in crates/ccteam-core/src/harness.rs sigkill_pid/sigterm_pid). ccteam architecture is tmux + inotify + POSIX signals at its foundation, so Windows is genuinely out of scope. Drop from matrix; document WSL2 path in README + quickstart + install.sh. Native Windows port = V0.7+ candidate if ever. - macos-arm64 + macos-x64 ✗ rolldown native binding (.darwin-arm64.node / .darwin-universal.node) missing. Root cause: package-lock.json was generated on linux and only resolves the linux-x64 rolldown binding; macOS `npm install` honored the lockfile and skipped the darwin optionalDependencies. Fix: split the SPA install step by runner.os — linux keeps `npm ci --include=optional`, macOS does `rm -f package-lock.json && npm install --include=optional` to force a fresh platform-correct resolution. Both run before `cargo build`, so the ccteam-web build.rs (which skips its own `npm install` when node_modules/ exists) picks up the right native binding. Post-merge: maintainer deletes v0.6.6 tag remote+local + re-tags fixed HEAD (pre-v1.0 destructive ops authorized per CLAUDE.md §五 #3). No version bump, no baseline change (1639/1). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
npm ci --include=optional, macOSrm -f package-lock.json && npm install --include=optionalto force darwin native binding fetchPackage (windows)pwsh step + .zip from upload-artifact glob + .zip fromgh release createasset listDiagnosis
v0.6.6 release run #26355340751 failed 3/4 platforms:
libc::SIGKILLonx86_64-pc-windows-msvctarget (crates/ccteam-core/src/harness.rs:574/589POSIX-only)@rolldown/binding-darwin-*) missing becausepackage-lock.jsononly resolves@rolldown/binding-linux-x64-gnu(generated on linux dev machine); macOSnpm installhonors the lockfile and skips darwinoptionalDependenciesLocal verification
cargo fmt --all -- --checkcleancargo build --release --bin ccteamsucceedscd crates/ccteam-web/web && rm -f package-lock.json && npm install --include=optional && npm run buildsucceeds (simulates macOS path on linux; can't directly verify darwin binding fetch, but proves the lockfile-clear + install flow works)cargo test --workspace --locked --no-fail-fast→ 1639/1 baseline (only flake =workflow_summary_reflects_agent_spawn_and_done_events, per CLAUDE.md §一)cargo clippy --workspace --all-targets --locked -- -D warningscleanRe-tag (post-merge)
Per pre-v1.0 + CLAUDE.md §五 #3 (no historical migration), maintainer will:
git push origin :refs/tags/v0.6.6(delete remote tag)git tag -d v0.6.6(delete local tag)git tag -a v0.6.6 <fixed-HEAD>+ pushScope
Diff stat
4 files changed, 39 insertions(+), 30 deletions(-)