Adjust version checking logging levels to debug#574
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughFirmware version check errors are downgraded from warning to debug level in both the client library and command mixin. Non-semver version detection now logs only at debug level with enhanced detail. Test assertions are updated to match the new message formats. ChangesFirmware Version Checking Log Level Reduction
🎯 2 (Simple) | ⏱️ ~8 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
057ada9 to
58957ae
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
This PR updates version-checking and firmware parsing log messages from
WARNINGtoDEBUGlevel.Changes
openevsehttp/client.py:"Unable to find firmware version."from warning to debug."Non-semver firmware version detected: %s".openevsehttp/commands.py:"Unable to find firmware version."from warning to debug."Non-semver firmware version detected."underAwesomeVersionCompareExceptionfrom warning to debug.tests/:test_client.pyandtest_commands.pyto match the updated debug log string (without the trailing dot).These changes eliminate verbose log spamming on integration startup or when utilizing custom firmware versions.
Summary by CodeRabbit