Skip to content

Add fail to curl#72

Merged
AHGIJMKLKKZNPJKQR merged 1 commit intomainfrom
fix-automation
Apr 10, 2026
Merged

Add fail to curl#72
AHGIJMKLKKZNPJKQR merged 1 commit intomainfrom
fix-automation

Conversation

@AHGIJMKLKKZNPJKQR
Copy link
Copy Markdown
Member

Description

The asdf step fails and is overly complicated, we can just add uv on the runner

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the asdf-based tool installation from the release bump script (relying on uv being present on the runner) and adds a notification log line in the room manager example.

Changes:

  • Drop the asdf plugin/install step from release-automation/bump-version.sh and rely on uv.
  • Minor formatting adjustment in the OpenAPI download command in the bump script.
  • Add a “received notification” output line in RoomService.handle_notification.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

File Description
release-automation/bump-version.sh Removes asdf-based setup and continues version bump + OpenAPI client update using uv.
examples/room_manager/room_service.py Adds a notification logging/output line when handling webhook notifications.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@roznawsk roznawsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failing is sus but unrelated

@AHGIJMKLKKZNPJKQR AHGIJMKLKKZNPJKQR changed the title Don't use asdf in the bump-version script Add fail to curl Apr 10, 2026
@AHGIJMKLKKZNPJKQR AHGIJMKLKKZNPJKQR merged commit 0d8cafb into main Apr 10, 2026
4 of 7 checks passed
@AHGIJMKLKKZNPJKQR AHGIJMKLKKZNPJKQR deleted the fix-automation branch April 10, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants