FCE-2851: Add missing useCallbacks#482
Merged
MiloszFilimowski merged 2 commits intomainfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to prevent unnecessary re-renders by wrapping returned functions in useCallback across three hooks in the react-client package. The changes affect useSandbox.ts, useStatistics.ts, and useScreenshareManager.ts, wrapping their returned functions with useCallback to maintain stable function references across renders.
Changes:
- Added
useCallbackwrappers to function returns in three hooks to stabilize function references - Updated imports to include
useCallbackfrom React - Specified dependency arrays for all memoized callbacks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/react-client/src/hooks/useStatistics.ts | Wrapped getStatistics in useCallback with client ref dependency |
| packages/react-client/src/hooks/useSandbox.ts | Wrapped three sandbox API functions in useCallback with sandboxApiUrl dependency |
| packages/react-client/src/hooks/internal/useScreenshareManager.ts | Wrapped multiple callbacks including startStreaming, replaceTracks, and setTracksMiddleware with state dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-client/src/hooks/internal/useScreenshareManager.ts
Outdated
Show resolved
Hide resolved
czerwiukk
approved these changes
Feb 24, 2026
MiloszFilimowski
deleted the
mfilimowski/fce-2851-missing-usecallbacks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrap returned functions in
useCallbackacross 3 hooks inreact-client:useSandbox.ts—getSandboxPeerToken,getSandboxViewerToken,getSandboxLivestreamuseStatistics.ts—getStatisticsuseScreenshareManager.ts—startStreaming,setTracksMiddleware(returned), plus 3 internal helpers they depend on (getDisplayName,addTrackToFishjamClient,replaceTracks)Motivation and Context
These functions were recreated on every render, causing unnecessary re-renders in consuming components and repeated effect executions when used as dependencies.
Documentation impact
Types of changes
not work as expected)