Skip to content
This repository was archived by the owner on Aug 2, 2024. It is now read-only.

Update README to use Fishjam (rebranding) #3

Merged
karkakol merged 4 commits into from
May 16, 2024
Merged

Update README to use Fishjam (rebranding) #3

karkakol merged 4 commits into from
May 16, 2024

Conversation

@karkakol
Copy link
Member

@karkakol karkakol commented May 15, 2024 •
edited by mironiasty
Loading

Update README file to use new name - Fishjam

@mironiasty
Copy link

mironiasty commented May 16, 2024

Can you also update utm_campain parameter in links?

@mironiasty mironiasty changed the title update readme Update README for rebranding May 16, 2024
@mironiasty mironiasty changed the title Update README for rebranding Update README to use Fishjam (rebranding) May 16, 2024
@karkakol karkakol requested a review from kamil-stasiak May 16, 2024 12:05
balins
balins approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@balins balins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still references to Fishjam in the room-manager example, but if this is how it was supposed to be then go for it.
Also, please do an interactive rebase to squash commits like format and duplicates, or at least use squash and merge.

@karkakol karkakol merged commit 4d8dc10 into main May 16, 2024
@karkakol karkakol deleted the karkakol/update_readme branch May 16, 2024 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mironiasty mironiasty Awaiting requested review from mironiasty

2 more reviewers

@kamil-stasiak kamil-stasiak kamil-stasiak approved these changes

@balins balins balins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@karkakol @mironiasty @kamil-stasiak @balins