Conversation
roznawsk
force-pushed
the
pypi-release
branch
from
158602e to
42141ba
Compare
roznawsk
force-pushed
the
pypi-release
branch
from
42141ba to
83aff36
Compare
roznawsk
force-pushed
the
pypi-release
branch
from
53e26c5 to
6ca6f3e
Compare
roznawsk
force-pushed
the
pypi-release
branch
from
8cdf995 to
f64dab0
Compare
LVala
approved these changes
Sep 12, 2023
sgfn
approved these changes
Sep 12, 2023
Comment on lines
6
to
+14
| openapi-generator-cli generate \ | ||
| -i https://raw.githubusercontent.com/jellyfish-dev/jellyfish/main/openapi.yaml \ | ||
| -g python \ | ||
| -o openapi \ | ||
| -o $TMP_DIR \ | ||
| -t templates \ | ||
| --package-name openapi_client \ | ||
| --global-property apis,models,modelTests=false,supportingFiles | ||
|
|
||
| rm -rf openapi/{docs,test,.github,.openapi-generator,.gitignore,.gitlab-ci.yml,.travis.yml,.openapi-generator-ignore,git_push.sh,README.md,setup.cfg,test-requirements.txt,tox.ini} | ||
| --package-name jellyfish.$PACKAGE_NAME \ | ||
| --global-property apis,models,modelTests=false,apiTests=false,modelDocs=false,apiDocs=false,supportingFiles | ||
|
|
||
| rm -rf jellyfish/$PACKAGE_NAME |
Member
There was a problem hiding this comment.
This isn't a big issue since we have version control, but you could consider exiting without deleting the old _openapi_client directory if the generate command failed
roznawsk
force-pushed
the
pypi-release
branch
from
030a04f to
5dddff5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for package release on PyPI:
pyproject.tomlconfigurationjellyfishfor testing purposes the package is released on test.pypi: https://test.pypi.org/project/jellyfish-server-sdk/
I think we can fully automatise the release procedure when releasing JF 0.2.0.