fix: hide grid cursor highlight when unfocused#40
Merged
Conversation
The unfocused-cursor branch applied a hardcoded dark-gray background (color 236) to the last-selected row even when the grid had no focus. This created a visible ghost highlight that disrupted stripe coloring and confused users about which row was selected. Drop the elif branch so unfocused cursor rows render with normal stripe or grid-bg styling, identical to any other non-cursor row. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When _PREFIX_SCREEN_quit() activates a confirm overlay (marking dirty + setting a focus request) without navigating screens, the global handler fell through with no draw call. The overlay was dirty but invisible until the *next* keypress, which was consumed by the stale focus owner before the focus ring was rebuilt. Add _shellframe_shell_draw_if_dirty in the else branch (quit fn ran but no screen transition occurred) so overlays appear before the next read. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\033[48;5;236m), creating a visible ghost highlight that disrupted stripe row coloring.elif (( _is_cursor ))branch inshellframe_grid_renderso unfocused cursor rows fall through to normal stripe/grid-bg logic — identical to any non-cursor row.Test plan
🤖 Generated with Claude Code