feat: Fission theme, empty-state splash, footer hint contrast#36
Merged
feat: Fission theme, empty-state splash, footer hint contrast#36
Conversation
… fix
- Add src/themes/fission.sh — dark void background with electric sky-blue
accents (#00afff), inspired by fissible.dev. Named "Fission" to celebrate
the ShellQL v1.0 launch.
- Render a centered ASCII splash ("ShellQL / SQLite Workbench / Select a
table to begin") in the browser empty state instead of a bare fill.
All strings are ASCII-only to avoid stale-cell ghosting from multi-byte chars.
- Add SHQL_THEME_FOOTER_HINT_COLOR to fission and cascade themes; footer
render now falls back to SHELLFRAME_GRAY only when the theme omits it.
Fixes unreadable grey-on-steel-blue footer text in the Fission theme.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When _SHQL_QUERY_CTX_EDITOR_ACTIVE_<ctx>=1 the user is composing SQL; key events must reach the editor unchanged. Guard the export-open branch so [x] only triggers export when the editor is in button/results mode. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/themes/fission.sh) — dark void background with electric sky-blue accents (#00afff/color 39), deep steel-blue header/footer bars, and white primary text. Inspired by fissible.dev. Named "Fission" to celebrate the ShellQL v1.0 launch.shellframe_fb_print.SHQL_THEME_FOOTER_HINT_COLORto the theme API._shql_TABLE_footer_rendernow uses this variable (falling back toSHELLFRAME_GRAY) so themes can control footer text legibility. Fission sets it to color 117 (#87d7ff, light sky blue), cascade to color 183 (pale purple). Fixes unreadable dark-gray text on Fission's steel-blue footer.Test plan
SHQL_THEME=fission SHELLFRAME_DIR=../shellframe bash bin/shql tests/fixtures/demo.sqlite— verify dark bg, blue header/footer, readable hint textSHQL_THEME=cascade— verify footer hint text is pale purple and readableSHQL_THEME=basic— verify footer hint falls back to default gray (no regression)🤖 Generated with Claude Code