Feat: add union type to nnc field - #153
Merged
Merged
Conversation
hugomrdias
requested changes
Mar 1, 2024
| rsc: z.string().url(), | ||
| nnc: z.string(), | ||
| nnc: z.union([ | ||
| z.string(), |
Member
There was a problem hiding this comment.
this should be empty string, not any string according to homestar schema
Member
Author
There was a problem hiding this comment.
@hugomrdias thanks 👍🏼 is z.string().length(0) the correct way to do that with zod? That's what I'm assuming based on the docs
hugomrdias
approved these changes
Mar 1, 2024
Bumps [@bytecodealliance/jco](https://github.com/bytecodealliance/jco) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/bytecodealliance/jco/releases) - [Commits](bytecodealliance/jco@1.0.1...1.0.2) --- updated-dependencies: - dependency-name: "@bytecodealliance/jco" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
avivash
force-pushed
the
avivash/nnc-union-type
branch
from
March 1, 2024 18:40
cf90bfb to
d4388f5
Compare
Member
Author
|
i borked the signing. i'll clean this up shortly |
avivash
force-pushed
the
avivash/nnc-union-type
branch
2 times, most recently
from
March 1, 2024 19:05
839e1d8 to
2ee7932
Compare
avivash
force-pushed
the
avivash/nnc-union-type
branch
from
March 1, 2024 19:08
2ee7932 to
b4e5fb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating the
nncschema field to support objects of IPLD bytes. This is needed so we can send a nonce to Homestar to enable replaysNote: I haven't tested this yet, but it looks like
zodsupports union types in this format 🤷🏼Link to sister PR
everywhere-computer/every-cli#6
Type of change