Update compiling instructions and rename potential conflicting wfcli directory#171
Merged
erwinvaneyk merged 1 commit intomasterfrom Jul 18, 2018
Merged
Update compiling instructions and rename potential conflicting wfcli directory#171erwinvaneyk merged 1 commit intomasterfrom
erwinvaneyk merged 1 commit intomasterfrom
Conversation
erwinvaneyk
force-pushed
the
compiling-wfcli-conflict
branch
from
f5bfebc to
625f9de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback of @soamvasani, the instructions for compiling are too ambiguous. Since writing the instructions the
build/wfclidirectory was added, causing users that followed thecompiling.mdinstructions literally to hit the following error when building:go install github.com/fission/fission-workflows/cmd/wfcli: build output "wfcli" already exists and is a directoryThis error is caused because the build artifact (
wfcli) conflicts with thebuild/wfcliwhen building from thebuild/directory. Building from any other directory would not cause this error.To fix this issue, I...
build/wfclitobuild/wfcli-dockerto avoid the naming conflictcompiling.mdinstructions to reflect the current state and also be more thorough in explaining the options.