Skip to content

Propagate HTTP invocation context#177

Merged
erwinvaneyk merged 3 commits intomasterfrom
http-invocation-context
Jul 25, 2018
Merged

Propagate HTTP invocation context#177
erwinvaneyk merged 3 commits intomasterfrom
http-invocation-context

Conversation

@erwinvaneyk
Copy link
Member

This PR addresses two things:

  • The propagation of cancellation signals from the apiserver. When the HTTP connection is closed prematurely with a synchronous invocation, this is now interpreted as a signal to cancel the invocation. An explicit integration test is added to verify correct behaviour on cancellation.
  • The synchronous invocation now listens for completion events of the invocation, instead of polling every 100ms. This should improve the latency of the workflow invocation as perceived by the user.

@xiekeyang - want to review this?

This should now make it possible again to cancel the workflow by closing
the HTTP connection.
Fixed a bug in pubsub where unsubscribing did not update the existing list of subscriptions
@erwinvaneyk erwinvaneyk force-pushed the http-invocation-context branch 2 times, most recently from 742527b to 51ee90e Compare July 25, 2018 09:36
@xiekeyang
Copy link
Contributor

@erwinvaneyk No problem, I'm taking look on it.

@erwinvaneyk erwinvaneyk force-pushed the http-invocation-context branch from 51ee90e to 804e7de Compare July 25, 2018 12:22
@erwinvaneyk erwinvaneyk merged commit 26e6ac4 into master Jul 25, 2018
@erwinvaneyk erwinvaneyk deleted the http-invocation-context branch July 25, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants