Skip to content

chore: disable memory-lint Phase B.5 (trial rolled back)#128

Merged
fitz123 merged 1 commit into
mainfrom
chore/disable-memory-lint-b5-trial
May 28, 2026
Merged

chore: disable memory-lint Phase B.5 (trial rolled back)#128
fitz123 merged 1 commit into
mainfrom
chore/disable-memory-lint-b5-trial

Conversation

@fitz123
Copy link
Copy Markdown
Owner

@fitz123 fitz123 commented May 28, 2026

Summary

Roll back the memory-lint Phase B.5 trial introduced in #124. Single-line flag flip: LINT_PHASE_B5_ENABLED=truefalse.

Trial result (ADR-069, 2026-05-17 → 2026-05-28, ended day 11 of planned 30)

Metric Value over 8 nightly runs
Candidates evaluated ~1500 (unstable: 12→179→128→353)
Contradictions detected by B.5 0
Auto-resolved 0
False positives 0

Decisive finding: a real cross-type contradiction arose (a user-type file claimed an activity was active while the related project-type file was marked SETTLED). Phase B.5 missed it — its candidate filter uses "same type" as a match signal, so cross-type pairs can't reach the ≥2-signal threshold. Cross-type drift is the most dangerous class, and the filter is structurally blind to it. The pre-existing narrative "Noted for Review" digest (predates this trial) caught the case instead.

Conclusion: the algorithmic cross-file lint found nothing in ~1500 evaluations and missed the one real case, while burning LLM judgment calls on up to 36% of all file pairs nightly. The free, pre-existing narrative digest does the actual work. Rolled back.

What changes

  • LINT_PHASE_B5_ENABLED flag → false (skill skips Phase B.5; Phases 0/A/B/C/D run as before)
  • confidence / revisit_if frontmatter still applied by Phase C (forward-compatible, harmless, kept)
  • Narrative "Noted for Review" digest retained — unchanged, it's the part that works

Test plan

  • grep -q 'LINT_PHASE_B5_ENABLED=false' .claude/skills/memory-consolidation/SKILL.md
  • Next nightly consolidation run: no Phase B.5 lint, no memory/lint-stats.jsonl append, no Pending Review writes

Notes

The trial harness (feature flag + stats file + reminder + pre-defined rollback criteria) worked exactly as intended — reached a confident rollback in 11 days with zero damage. Reusable pattern for future experiments.

🤖 Generated with Claude Code

The 2026-05-17→05-28 trial (ADR-069) found Phase B.5 cross-file
contradiction lint did not earn its keep:

- 0 contradictions detected across 8 nightly runs (~1500 candidate
  evaluations)
- Structurally MISSED the one real cross-type contradiction that arose:
  the candidate filter uses "same type" as a match signal, so a
  user-file vs project-file contradiction can't reach the >=2-signal
  threshold. Cross-type drift is exactly the most dangerous class.
- The pre-existing narrative "Noted for Review" digest (predates this
  trial) caught that case instead.

Flip LINT_PHASE_B5_ENABLED to false. Phase C still applies confidence/
revisit_if frontmatter (forward-compatible, harmless). Narrative digest
retained — it's the part that works.

Retrospective: reference/tasks/workspace-txyu/retrospective.md (private).
ADR-069 -> SUPERSEDED.
Copilot AI review requested due to automatic review settings May 28, 2026 19:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@fitz123 fitz123 merged commit 1fbcfab into main May 28, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants