kbs/admin: modularize admin authentication and authorization #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the admin module from simple monolithic implementations to a modular architecture that separates token verification from authorization decisions. Key changes: - Split admin functionality into two independent modules: * token_verifier: Handles token parsing and verification (BearerJwt) * authorization: Handles access control decisions (RegexAcl) - Replace simple backend types (allow_all, deny_all, simple) with trait-based architecture for better extensibility - Update AdminConfig to use "mode" enum (InsecureAllowAll, DenyAll, Enforce) instead of "type" for clearer semantics - Enforce mode requires both token_verifier and authorizer configuration - Improve error handling with detailed reason messages in AdminAccessDenied This refactoring improves code organization, maintainability, and makes it easier to add new token verifiers or authorization strategies in the future. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the admin module from simple monolithic implementations to a modular architecture that separates token verification from authorization decisions.
Key changes:
This refactoring improves code organization, maintainability, and makes it easier to add new token verifiers or authorization strategies in the future.
Note that this PR does not handle the following things