[Feature] Union Data #70

fivetran-avinash · 2025-11-04T20:06:43Z

PR Overview

Package version introduced in this PR:

1.2.0

This PR addresses the following Issue/Feature(s):

Ticket GA-1007458

Summary of changes:

Adding union data for ERTC support.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

fivetran-jamie

Overall looks good! Some requested changes

fivetran-jamie · 2025-11-06T21:24:43Z

CHANGELOG.md

+## Feature Update
+- **Union Data Functionality**: This release supports running the package on multiple Intercom source connections. See the [README](https://github.com/fivetran/dbt_intercom/tree/main?tab=readme-ov-file#step-3-define-database-and-schema-variables) for details on how to leverage this feature.
+
+## Under the Hood


Suggested change

## Under the Hood

## Tests Update

Since these aren't really under the hood for customers (besides the consistency tests -- that part can live in an Under the Hood section)

fivetran-jamie · 2025-11-06T21:25:40Z

CHANGELOG.md

+| Data Model(s) | Change type | Old | New | Notes |
+| ------------- | ----------- | ----| --- | ----- |
+| All models | New column | | `source_relation` | Identifies the source connection when using multiple Intercom connections |
+| `stg_intercom__tag` | New Data Type | `name` categorized as timestamp | `name` categorized as string | Modifies name to its proper string format. |


fivetran-jamie · 2025-11-06T21:39:49Z

integration_tests/tests/consistency/consistency_admin_metrics.sql

+    enabled=(var('fivetran_validation_tests_enabled', false))
+) }}
+
+{% set exclude_cols = ['source_relation'] + var('consistency_test_exclude_metrics', []) %}


Suggested change

{% set exclude_cols = ['source_relation'] + var('consistency_test_exclude_metrics', []) %}

{% set exclude_cols = var('consistency_test_exclude_metrics', []) %}

Before merging, can you remove source_relation from the exclusion columns?

fivetran-jamie · 2025-11-06T21:40:05Z

integration_tests/tests/consistency/consistency_company_enhanced.sql

+    enabled=(var('fivetran_validation_tests_enabled', false))
+) }}
+
+{% set exclude_cols = ['source_relation'] + var('consistency_test_exclude_metrics', []) %}


Suggested change

{% set exclude_cols = ['source_relation'] + var('consistency_test_exclude_metrics', []) %}

{% set exclude_cols = var('consistency_test_exclude_metrics', []) %}

Before merging, can you remove source_relation from the exclusion columns?

fivetran-jamie · 2025-11-06T21:40:53Z

integration_tests/tests/consistency/consistency_company_metrics.sql

+    enabled=(var('fivetran_validation_tests_enabled', false))
+) }}
+
+{% set exclude_cols = ['source_relation', 'all_company_tags'] + var('consistency_test_exclude_metrics', []) %}


Suggested change

{% set exclude_cols = ['source_relation', 'all_company_tags'] + var('consistency_test_exclude_metrics', []) %}

{% set exclude_cols = ['all_company_tags'] + var('consistency_test_exclude_metrics', []) %}

Same request to remove source_relation before merging

fivetran-jamie · 2025-11-06T21:54:38Z

models/intercom__admin_metrics.sql


    left join team
        on team.team_id = team_admin.team_id
+        and team.source_relation = admin_table.source_relation


Suggested change

and team.source_relation = admin_table.source_relation

and team.source_relation = team_admin.source_relation

Since we're joining team and team_admin here

fivetran-jamie · 2025-11-06T21:55:25Z

models/intercom__company_enhanced.sql

+
    left join tags
      on tags.tag_id = company_tags.tag_id
+      and tags.source_relation = company_history.source_relation


Suggested change

and tags.source_relation = company_history.source_relation

and tags.source_relation = company_tags.source_relation

fivetran-jamie · 2025-11-06T21:56:52Z

models/intercom__contact_enhanced.sql

+
    left join tags
      on tags.tag_id = contact_tags.tag_id
+      and tags.source_relation = contact_latest.source_relation


Suggested change

and tags.source_relation = contact_latest.source_relation

and tags.source_relation = contact_tags.source_relation

fivetran-jamie · 2025-11-06T21:58:21Z

models/intercom__contact_enhanced.sql


  left join company_history
    on company_history.company_id = contact_company_history.company_id
+    and company_history.source_relation = contact_latest.source_relation


Suggested change

and company_history.source_relation = contact_latest.source_relation

and company_history.source_relation = contact_company_history.source_relation

fivetran-jamie · 2025-11-06T21:58:56Z

models/intercom__conversation_enhanced.sql

+
    left join tags
        on tags.tag_id = conversation_tags.tag_id
+        and tags.source_relation = latest_conversation.source_relation


Suggested change

and tags.source_relation = latest_conversation.source_relation

and tags.source_relation = conversation_tags.source_relation

…intercom into feature/union-data

fivetran-avinash

@fivetran-jamie Ready for re-review!

fivetran-jamie

LGTM -- reminder to regen the docs after the last round of changes

fivetran-jamie · 2025-11-07T00:06:44Z

CHANGELOG.md

+[PR #70](https://github.com/fivetran/dbt_intercom/pull/70) introduces the following updates:
+
+## Schema/Data Changes
+**3 total change • 2 possible breaking changes**


Suggested change

**3 total change • 2 possible breaking changes**

**3 total changes • 2 possible breaking changes**

…intercom into feature/union-data

Union Data Claude.md implementation

6af24b6

fivetran-avinash changed the title ~~Union Data Claude.md implementation~~ [Feature] Union Data Nov 5, 2025

fivetran-avinash self-assigned this Nov 5, 2025

add consistency tests, documentation

a1fc2cc

fivetran-avinash marked this pull request as ready for review November 5, 2025 20:05

fivetran-avinash requested a review from fivetran-jamie November 5, 2025 20:24

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Nov 5, 2025

Generate dbt docs via GitHub Actions

d12601b

fivetran-jamie requested changes Nov 6, 2025

View reviewed changes

fivetran-avinash added 4 commits November 6, 2025 14:44

Data type changes

41bc823

Merge branch 'feature/union-data' of https://github.com/fivetran/dbt_…

4e1ea88

…intercom into feature/union-data

models/sources.yml removed

2441dd4

PR changes

9ae369a

fivetran-avinash commented Nov 6, 2025

View reviewed changes

fivetran-avinash removed the docs:ready Triggers the docs generator workflow. label Nov 7, 2025

fivetran-jamie approved these changes Nov 7, 2025

View reviewed changes

fivetran-jamie reviewed Nov 7, 2025

View reviewed changes

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Nov 7, 2025

github-actions bot and others added 3 commits November 7, 2025 00:08

Generate dbt docs via GitHub Actions

5e64d6b

PR changes

f13809a

Merge branch 'feature/union-data' of https://github.com/fivetran/dbt_…

3aed829

…intercom into feature/union-data

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Nov 7, 2025

Generate dbt docs via GitHub Actions

d022169

fivetran-avinash merged commit 6da861b into main Nov 7, 2025
9 checks passed

	\| `stg_intercom__tag` \| New Data Type \| `name` categorized as timestamp \| `name` categorized as string \| Modifies name to its proper string format. \|
	\| `stg_intercom__tag` \| New data type \| `name` categorized as timestamp \| `name` categorized as string \| Modifies name to its proper string format. \|

	{% set exclude_cols = ['source_relation'] + var('consistency_test_exclude_metrics', []) %}
	{% set exclude_cols = var('consistency_test_exclude_metrics', []) %}

	{% set exclude_cols = ['source_relation', 'all_company_tags'] + var('consistency_test_exclude_metrics', []) %}
	{% set exclude_cols = ['all_company_tags'] + var('consistency_test_exclude_metrics', []) %}

	and team.source_relation = admin_table.source_relation
	and team.source_relation = team_admin.source_relation

	and tags.source_relation = company_history.source_relation
	and tags.source_relation = company_tags.source_relation

	and tags.source_relation = contact_latest.source_relation
	and tags.source_relation = contact_tags.source_relation

	and company_history.source_relation = contact_latest.source_relation
	and company_history.source_relation = contact_company_history.source_relation

	and tags.source_relation = latest_conversation.source_relation
	and tags.source_relation = conversation_tags.source_relation

	3 total change • 2 possible breaking changes
	3 total changes • 2 possible breaking changes

[Feature] Union Data #70

[Feature] Union Data #70

Uh oh!

Conversation

fivetran-avinash commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fivetran-avinash commented Nov 4, 2025 •

edited

Loading